From 07c0c2eb0a5970db614ebce1060fc79d6904bdfd Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann Date: Mon, 23 May 2022 21:45:04 +0800 Subject: [PATCH] OvmfPkg: fix PcdFSBClock kvm FSB clock is 1GHz, not 100 MHz. Timings are off by factor 10. Fix all affected build configurations. Not changed: Microvm and Cloudhw (they have already have the correct value), and Xen (has no fixed frequency, the PCD is configured at runtime by platform initialization code). Fixes: c37cbc030d96 ("OvmfPkg: Switch timer in build time for OvmfPkg") Reported-by: Laszlo Ersek Signed-off-by: Gerd Hoffmann Reviewed-by: Jiewen Yao --- OvmfPkg/AmdSev/AmdSevX64.dsc | 2 +- OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2 +- OvmfPkg/OvmfPkgIa32.dsc | 2 +- OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- OvmfPkg/OvmfPkgX64.dsc | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc index bead9722ea..fc1fdb2e22 100644 --- a/OvmfPkg/AmdSev/AmdSevX64.dsc +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc @@ -578,7 +578,7 @@ !include OvmfPkg/OvmfTpmPcds.dsc.inc - gEfiMdePkgTokenSpaceGuid.PcdFSBClock|100000000 + gEfiMdePkgTokenSpaceGuid.PcdFSBClock|1000000000 [PcdsDynamicHii] !include OvmfPkg/OvmfTpmPcdsHii.dsc.inc diff --git a/OvmfPkg/IntelTdx/IntelTdxX64.dsc b/OvmfPkg/IntelTdx/IntelTdxX64.dsc index 00bc1255bc..dd8d446f4a 100644 --- a/OvmfPkg/IntelTdx/IntelTdxX64.dsc +++ b/OvmfPkg/IntelTdx/IntelTdxX64.dsc @@ -511,7 +511,7 @@ # Set ConfidentialComputing defaults gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0 - gEfiMdePkgTokenSpaceGuid.PcdFSBClock|100000000 + gEfiMdePkgTokenSpaceGuid.PcdFSBClock|1000000000 ################################################################################ # diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc index c16a840fff..a9841cbfc3 100644 --- a/OvmfPkg/OvmfPkgIa32.dsc +++ b/OvmfPkg/OvmfPkgIa32.dsc @@ -651,7 +651,7 @@ gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0 !if $(CSM_ENABLE) == FALSE - gEfiMdePkgTokenSpaceGuid.PcdFSBClock|100000000 + gEfiMdePkgTokenSpaceGuid.PcdFSBClock|1000000000 !endif [PcdsDynamicHii] diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc index d3a80cb568..f7949780fa 100644 --- a/OvmfPkg/OvmfPkgIa32X64.dsc +++ b/OvmfPkg/OvmfPkgIa32X64.dsc @@ -659,7 +659,7 @@ gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0 !if $(CSM_ENABLE) == FALSE - gEfiMdePkgTokenSpaceGuid.PcdFSBClock|100000000 + gEfiMdePkgTokenSpaceGuid.PcdFSBClock|1000000000 !endif [PcdsDynamicDefault.X64] diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc index 7b3d48aac4..1448f925b7 100644 --- a/OvmfPkg/OvmfPkgX64.dsc +++ b/OvmfPkg/OvmfPkgX64.dsc @@ -684,7 +684,7 @@ gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0 !if $(CSM_ENABLE) == FALSE - gEfiMdePkgTokenSpaceGuid.PcdFSBClock|100000000 + gEfiMdePkgTokenSpaceGuid.PcdFSBClock|1000000000 !endif [PcdsDynamicHii] -- 2.39.2