From dde4aedc35ee3c06b67c1a5c4f392e7a0b0f8254 Mon Sep 17 00:00:00 2001 From: wang xiaofeng Date: Fri, 13 May 2016 11:20:28 +0800 Subject: [PATCH] PcAtChipsetPkg AcpiTimerLib: Fix a logic error if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister) & EnableMask) != EnableMask)) { The bracket place is not right, I think it should be if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister)) & EnableMask) != EnableMask) Cc: Ruiyu Ni Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: wang xiaofeng Reviewed-by: Star Zeng Reviewed-by: Liming Gao --- PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c b/PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c index ad855fe4f5..806a4f7ce2 100644 --- a/PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c +++ b/PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c @@ -89,7 +89,7 @@ AcpiTimerLibConstructor ( // // If ACPI I/O space is not enabled yet, program ACPI I/O base address and enable it. // - if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister) & EnableMask) != EnableMask)) { + if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister)) & EnableMask) != EnableMask) { PciWrite16 ( PCI_LIB_ADDRESS (Bus, Device, Function, PcdGet16 (PcdAcpiIoPciBarRegisterOffset)), PcdGet16 (PcdAcpiIoPortBaseAddress) -- 2.39.2