From 7aa06237b856fd6f8187cc1715a3fe08ab4e98ed Mon Sep 17 00:00:00 2001 From: Rodrigo Gonzalez Del Cueto Date: Thu, 22 Sep 2022 15:35:36 +0800 Subject: [PATCH] SecurityPkg: Remove enforcement of final GoIdle transition for CRB commands REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4077 Following the design described in the TCG specification, the driver implementation of the CRB protocol does not require enforcing completing the transition to goIdle at the end of a command sequence. Signed-off-by: Rodrigo Gonzalez Del Cueto Cc: Jiewen Yao Cc: Jian J Wang Reviewed-by: Jian J Wang --- SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c index 840265292a..1f9ac5ab5a 100644 --- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c +++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c @@ -381,19 +381,6 @@ GoIdle_Exit: // MmioWrite32 ((UINTN)&CrbReg->CrbControlRequest, PTP_CRB_CONTROL_AREA_REQUEST_GO_IDLE); - // - // Only enforce Idle state transition if execution fails when CRBIdleBypass==1 - // Leave regular Idle delay at the beginning of next command execution - // - if (GetCachedIdleByPass () == 1) { - Status = PtpCrbWaitRegisterBits ( - &CrbReg->CrbControlStatus, - PTP_CRB_CONTROL_AREA_STATUS_TPM_IDLE, - 0, - PTP_TIMEOUT_C - ); - } - return Status; } -- 2.39.2