From f2ad804f8bcfb961bce7a195374d7b797c5f017a Mon Sep 17 00:00:00 2001 From: jcarsey Date: Fri, 1 Apr 2011 22:19:02 +0000 Subject: [PATCH] remove duplicate memory de-allocation. Add function header comment. git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11500 6f19259b-4bc3-4df7-8a09-765794883524 --- ShellPkg/Library/UefiShellDebug1CommandsLib/Bcfg.c | 12 ++++++++---- ShellPkg/Library/UefiShellInstall1CommandsLib/Bcfg.c | 12 ++++++++---- 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Bcfg.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/Bcfg.c index d278ee60e6..e6884a2d59 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Bcfg.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Bcfg.c @@ -324,14 +324,10 @@ BcfgAddDebug1( } } } - if (FileNode != NULL) { - FreePool (FileNode); - } // //If always Free FilePath, will free devicepath in system when use "addh" // - if (FilePath!=NULL && !UseHandle) { FreePool (FilePath); } @@ -467,6 +463,14 @@ BcfgMoveDebug1( return (SHELL_SUCCESS); } +/** + Function to add optional data to an option. + + @param[in] OptData The optional data to add. + @param[in] Target The target of the operation. + + @retval SHELL_SUCCESS The operation was succesful. +**/ SHELL_STATUS EFIAPI BcfgAddOptDebug1( diff --git a/ShellPkg/Library/UefiShellInstall1CommandsLib/Bcfg.c b/ShellPkg/Library/UefiShellInstall1CommandsLib/Bcfg.c index ec03df1d60..aeb3fcd10e 100644 --- a/ShellPkg/Library/UefiShellInstall1CommandsLib/Bcfg.c +++ b/ShellPkg/Library/UefiShellInstall1CommandsLib/Bcfg.c @@ -324,14 +324,10 @@ BcfgAddInstall1( } } } - if (FileNode != NULL) { - FreePool (FileNode); - } // //If always Free FilePath, will free devicepath in system when use "addh" // - if (FilePath!=NULL && !UseHandle) { FreePool (FilePath); } @@ -467,6 +463,14 @@ BcfgMoveInstall1( return (SHELL_SUCCESS); } +/** + Function to add optional data to an option. + + @param[in] OptData The optional data to add. + @param[in] Target The target of the operation. + + @retval SHELL_SUCCESS The operation was succesful. +**/ SHELL_STATUS EFIAPI BcfgAddOptInstall1( -- 2.39.2