From 310b053a863a8908deeb1e7dd531a020493ba61c Mon Sep 17 00:00:00 2001 From: Jaben Carsey Date: Thu, 24 Sep 2015 20:44:00 +0000 Subject: [PATCH] Revert 18541 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jaben Carsey Reviewed-by: Jaben Carsey git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18542 6f19259b-4bc3-4df7-8a09-765794883524 --- .../Library/UefiShellTftpCommandLib/Tftp.c | 13 +++++-------- .../UefiShellTftpCommandLib.h | 3 ++- .../UefiShellTftpCommandLib.uni | Bin 8856 -> 8748 bytes 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c index e596c22723..d2f7046de0 100644 --- a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c +++ b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c @@ -2,7 +2,6 @@ The implementation for the 'tftp' Shell command. Copyright (c) 2015, ARM Ltd. All rights reserved.
- Copyright (c) 2015, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License @@ -15,8 +14,6 @@ #include "UefiShellTftpCommandLib.h" -#define EFI_IP4_CONFIG2_INTERFACE_INFO_NAME_LENGTH 32 - /* Constant strings and definitions related to the message indicating the amount of progress in the dowloading of a TFTP file. @@ -261,7 +258,7 @@ ShellCommandRunTftp ( EFI_HANDLE *Handles; UINTN HandleCount; UINTN NicNumber; - CHAR16 NicName[EFI_IP4_CONFIG2_INTERFACE_INFO_NAME_LENGTH]; + CHAR16 NicName[IP4_NIC_NAME_LENGTH]; EFI_HANDLE ControllerHandle; EFI_HANDLE Mtftp4ChildHandle; EFI_MTFTP4_PROTOCOL *Mtftp4; @@ -574,7 +571,7 @@ StringToUint16 ( return FALSE; } - *Value = (UINT16)Val; + *Value = Val; return TRUE; } @@ -626,7 +623,7 @@ GetNicName ( UnicodeSPrint ( NicName, - EFI_IP4_CONFIG2_INTERFACE_INFO_NAME_LENGTH, + IP4_NIC_NAME_LENGTH, SnpMode.IfType == NET_IFTYPE_ETHERNET ? L"eth%d" : L"unk%d" , @@ -947,8 +944,8 @@ CheckPacket ( CHAR16 Progress[TFTP_PROGRESS_MESSAGE_SIZE]; UINT64 NbOfKb; UINTN Index; - UINT64 LastStep; - UINT64 Step; + UINTN LastStep; + UINTN Step; if ((NTOHS (Packet->OpCode)) != EFI_MTFTP4_OPCODE_DATA) { return EFI_SUCCESS; diff --git a/ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.h b/ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.h index 993aa9e5bd..a73b86c85b 100644 --- a/ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.h +++ b/ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.h @@ -1,7 +1,7 @@ /** @file header file for NULL named library for 'tftp' Shell command functions. - Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved.
+ Copyright (c) 2010 - 2011, Intel Corporation. All rights reserved.
Copyright (c) 2015, ARM Ltd. All rights reserved.
This program and the accompanying materials @@ -21,6 +21,7 @@ #include #include +#include #include #include diff --git a/ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.uni b/ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.uni index 43b8cc5e7cd8726138c600b96b4ebbb1c960824c..607a3602d2a3aad30619c0844162e7399c0aba9a 100644 GIT binary patch delta 289 zcmbQ?y2fRK6SFac?nG-zeqDwDhD3&BhHM~N#E>$vQd-iPA)g_ap#Uh5$56?j!=S+6 z!=MLLrnhmrFN?e%Ln=cFLpe}Q5m1v614MN$Sak|R@#LQ@o!Uk~^#(wFc_?ZX7z}}8 z$zapr>Nn41trlihUnQCxI#jcgmg0z(Q=9mr}0h9rhcuzDT2l*u#X lx+XVpiA+8uDl|Djz5>MNEC#9p`8yS)YLY_U<~9W(CII6DN&o-= delta 329 zcmZ4EGQ)L(lesB_0)q!bDnmI#4v;JXLIs8ZhD3&BhHM~N#E=5yyE5bf#Z!U20wB(0 zC}v2Vm@Ccf!w|4>p)ZSQ2tyiBx`4r%A)g@^2or(IQzrAWc8Z5ExG{tPjZ**`ha|W8 zAZxWSw;zK)P|}qln89kYqKGi30)rug9#Cn>