From 01331951708f980fca1fb3a791ab544adcd3a5d0 Mon Sep 17 00:00:00 2001 From: Samer El-Haj-Mahmoud Date: Thu, 27 Nov 2014 01:01:43 +0000 Subject: [PATCH] MdeModulePkg: Misc comments and DEBUG messages Fixed some spelling typos in some comments. Added a couple of useful DEBUG messages Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud Reviewed-by: Feng Tian git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16450 6f19259b-4bc3-4df7-8a09-765794883524 --- MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c | 5 +++++ MdeModulePkg/Bus/Pci/UhciDxe/UhciSched.c | 2 +- MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 6 +++--- MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c | 4 ++++ 4 files changed, 13 insertions(+), 4 deletions(-) diff --git a/MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c b/MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c index ff99fe4461..319507cfa2 100644 --- a/MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c +++ b/MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c @@ -2,6 +2,7 @@ This file implements I2C Host Protocol which provides callers with the ability to do I/O transactions to all of the devices on the I2C bus. + Copyright (c) 2014, Hewlett-Packard Development Company, L.P.
Copyright (c) 2013 - 2014, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License @@ -672,6 +673,10 @@ I2cHostI2cBusConfigurationAvailable ( I2cHostContext->I2cEvent, &I2cHostContext->Status ); + + if (EFI_ERROR (Status)) { + DEBUG((DEBUG_ERROR, "I2cHostI2cBusConfigurationAvailable: Error starting I2C operation, %r\n", Status)); + } } /** diff --git a/MdeModulePkg/Bus/Pci/UhciDxe/UhciSched.c b/MdeModulePkg/Bus/Pci/UhciDxe/UhciSched.c index af3f4e5ecd..90f010c998 100644 --- a/MdeModulePkg/Bus/Pci/UhciDxe/UhciSched.c +++ b/MdeModulePkg/Bus/Pci/UhciDxe/UhciSched.c @@ -519,7 +519,7 @@ UhciCheckTdStatus ( // terminate the transfer // if (!IsLow && (TdHw->ShortPacket == 1) && (Len < Td->DataLen)) { - DEBUG ((EFI_D_INFO, "UhciCheckTdStatus: short packet read occured\n")); + DEBUG ((EFI_D_VERBOSE, "UhciCheckTdStatus: short packet read occured\n")); Finished = TRUE; goto ON_EXIT; diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c index 21c69ca6ef..4759579cab 100644 --- a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c @@ -257,7 +257,7 @@ SMM_IPL_EVENT_NOTIFICATION mSmmIplEvents[] = { // { TRUE, FALSE, &gEfiSmmConfigurationProtocolGuid, SmmIplSmmConfigurationEventNotify, &gEfiSmmConfigurationProtocolGuid, TPL_NOTIFY, NULL }, // - // Declare protocl notification on DxeSmmReadyToLock protocols. When this notification is etablished, + // Declare protocol notification on DxeSmmReadyToLock protocols. When this notification is established, // the associated event is immediately signalled, so the notification function will be executed and the // DXE SMM Ready To Lock Protocol will be found if it is already in the handle database. // @@ -659,7 +659,7 @@ SmmIplSmmConfigurationEventNotify ( /** Event notification that is fired every time a DxeSmmReadyToLock protocol is added - or if gEfiEventReadyToBootGuid is signalled. + or if gEfiEventReadyToBootGuid is signaled. @param Event The Event that is being processed, not used. @param Context Event Context, not used. @@ -694,7 +694,7 @@ SmmIplReadyToLockEventNotify ( } else { // // If SMM is not locked yet and we got here from gEfiEventReadyToBootGuid being - // signalled, then gEfiDxeSmmReadyToLockProtocolGuid was not installed as expected. + // signaled, then gEfiDxeSmmReadyToLockProtocolGuid was not installed as expected. // Print a warning on debug builds. // DEBUG ((DEBUG_WARN, "SMM IPL! DXE SMM Ready To Lock Protocol not installed before Ready To Boot signal\n")); diff --git a/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c b/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c index a35b4f2d0d..4b0159c4fa 100644 --- a/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c +++ b/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c @@ -11,6 +11,7 @@ always on the first sector of a media. The first sector also contains the legacy boot strap code. +Copyright (c) 2014, Hewlett-Packard Development Company, L.P.
Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License @@ -74,6 +75,9 @@ PartitionValidMbr ( // return FALSE since no block devices on a system are implemented // with INT 13h // + + DEBUG((EFI_D_INFO, "PartitionValidMbr: Bad MBR partition size EndingLBA(%1x) > LastLBA(%1x)\n", EndingLBA, LastLba)); + return FALSE; } -- 2.39.2