From 02ec23abebcb271a16fae94f8e3659bb9282880d Mon Sep 17 00:00:00 2001 From: Ard Biesheuvel Date: Mon, 18 Jun 2018 22:46:36 +0200 Subject: [PATCH] EmbeddedPkg/GdbSerialLib: avoid left shift of negative quantity Clang complains about left shifting a negative value being undefined. EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c:151:30: error: shifting a negative signed value is undefined [-Werror,-Wshift-negative-value] OutputData = (UINT8)((~DLAB<<7)|((BreakSet<<6)|((Parity<<3)|((StopBits<<2)| Data)))); Redefine all bit pattern constants as unsigned to work around this. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm --- EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c b/EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c index 069d87ca78..7931d1ac4e 100644 --- a/EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c +++ b/EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c @@ -40,11 +40,11 @@ //--------------------------------------------- // UART Register Bit Defines //--------------------------------------------- -#define LSR_TXRDY 0x20 -#define LSR_RXDA 0x01 -#define DLAB 0x01 -#define ENABLE_FIFO 0x01 -#define CLEAR_FIFOS 0x06 +#define LSR_TXRDY 0x20U +#define LSR_RXDA 0x01U +#define DLAB 0x01U +#define ENABLE_FIFO 0x01U +#define CLEAR_FIFOS 0x06U -- 2.39.2