From 1487c13ce00581bb94ee0baff64a4ce6c2ae0cea Mon Sep 17 00:00:00 2001 From: Laszlo Ersek Date: Tue, 19 Jan 2021 16:54:38 +0100 Subject: [PATCH] UefiCpuPkg/AcpiCpuData: update comments on register table fields MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit After commit e992cc3f4859 ("UefiCpuPkg PiSmmCpuDxeSmm: Reduce SMRAM consumption in CpuS3.c", 2021-01-11), it is valid for a CPU S3 Data DXE Driver to set "ACPI_CPU_DATA.PreSmmInitRegisterTable" and/or "ACPI_CPU_DATA.RegisterTable" to 0, in case none of the CPUs needs a register table of the corresponding kind, during S3 resume. Document this fact in the "UefiCpuPkg/Include/AcpiCpuData.h" header file. Cc: Eric Dong Cc: Philippe Mathieu-Daudé Cc: Rahul Kumar Cc: Ray Ni Cc: Star Zeng Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3159 Signed-off-by: Laszlo Ersek Reviewed-by: Ray Ni Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210119155440.2262-3-lersek@redhat.com> Reviewed-by: Star Zeng --- UefiCpuPkg/Include/AcpiCpuData.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/UefiCpuPkg/Include/AcpiCpuData.h b/UefiCpuPkg/Include/AcpiCpuData.h index b5a69ad80c..62a01b2c6b 100644 --- a/UefiCpuPkg/Include/AcpiCpuData.h +++ b/UefiCpuPkg/Include/AcpiCpuData.h @@ -178,6 +178,8 @@ typedef struct { // If TableLength is > 0, then elements of RegisterTableEntry are used to // initialize the CPU that matches InitialApicId, during an ACPI S3 resume, // before SMBASE relocation is performed. + // If a register table is not required for any one of the CPUs, then + // PreSmmInitRegisterTable may be set to 0. // EFI_PHYSICAL_ADDRESS PreSmmInitRegisterTable; // @@ -187,6 +189,8 @@ typedef struct { // If TableLength is > 0, then elements of RegisterTableEntry are used to // initialize the CPU that matches InitialApicId, during an ACPI S3 resume, // after SMBASE relocation is performed. + // If a register table is not required for any one of the CPUs, then + // RegisterTable may be set to 0. // EFI_PHYSICAL_ADDRESS RegisterTable; // -- 2.39.2