From 1549328f5f48c657137c3ead96f2ad3586713a33 Mon Sep 17 00:00:00 2001 From: "Carsey, Jaben" Date: Sat, 28 Apr 2018 06:32:42 +0800 Subject: [PATCH] BaseTools: AutoGen - refactor function to remove extra variables we dont need to keep data we already have in different formats... Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey Reviewed-by: Yonghong Zhu --- BaseTools/Source/Python/AutoGen/GenVar.py | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/GenVar.py b/BaseTools/Source/Python/AutoGen/GenVar.py index 4f894f3f73..e3595bb623 100644 --- a/BaseTools/Source/Python/AutoGen/GenVar.py +++ b/BaseTools/Source/Python/AutoGen/GenVar.py @@ -110,17 +110,14 @@ class VariableMgr(object): @staticmethod def assemble_variable(valuedict): - ordered_offset = sorted(valuedict.keys()) - ordered_value = [valuedict[k] for k in ordered_offset] + ordered_valuedict_keys = sorted(valuedict.keys()) var_value = [] - num = 0 - for offset in ordered_offset: - if offset < len(var_value): + for current_valuedict_key in ordered_valuedict_keys: + if current_valuedict_key < len(var_value): raise - for _ in xrange(offset - len(var_value)): + for _ in xrange(current_valuedict_key - len(var_value)): var_value.append('0x00') - var_value += ordered_value[num] - num +=1 + var_value += valuedict[current_valuedict_key] return var_value def process_variable_data(self): -- 2.39.2