From 1bbb51266482f2b73771cb23a4180f5617bdcecb Mon Sep 17 00:00:00 2001 From: Star Zeng Date: Thu, 19 Jul 2018 18:29:52 +0800 Subject: [PATCH] FmpDevicePkg FmpDxe: Return 0 when LSV check is not required Current code return 1 when LSV check is not required, but 1 LSV will make 0 Version capsule image update failed. 0 LSV is valid, this patch updates the code to return 0 when LSV check is not required We can see even the DEFAULT_LOWESTSUPPORTEDVERSION is 0. Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng Reviewed-by: Michael D Kinney --- FmpDevicePkg/FmpDxe/FmpDxe.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c index c0c1383723..091f950b95 100644 --- a/FmpDevicePkg/FmpDxe/FmpDxe.c +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c @@ -210,12 +210,15 @@ GetLowestSupportedVersion ( // Get the LowestSupportedVersion. // - DeviceLibLowestSupportedVersion = DEFAULT_LOWESTSUPPORTEDVERSION; - ReturnLsv = PcdGet32 (PcdFmpDeviceBuildTimeLowestSupportedVersion); if (!IsLowestSupportedVersionCheckRequired ()) { - return 1; + // + // Any Version can pass the 0 LowestSupportedVersion check. + // + return 0; } + ReturnLsv = PcdGet32 (PcdFmpDeviceBuildTimeLowestSupportedVersion); + // // Check the FmpDeviceLib // -- 2.39.2