From 32bcdfa512bda825d968c69cdeb7d5da89ced62e Mon Sep 17 00:00:00 2001 From: Gaurav Jain Date: Wed, 18 Mar 2020 15:54:19 +0530 Subject: [PATCH] EmbeddedPkg/RealTimeClockRuntimeDxe: Drop ASSERTs on function arguments ASSERT in SetTime_Conf Consistency Test. SCT Test expect return as Invalid Parameter. So removed ASSERT(). While at it, check that the NanoSecond field is within the range given by the UEFI specification. Signed-off-by: Gaurav Jain Reviewed-by: Ard Biesheuvel --- EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c index 08fb9b0100..20f1fa640e 100644 --- a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c +++ b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c @@ -85,10 +85,6 @@ IsDayValid ( IN EFI_TIME *Time ) { - ASSERT (Time->Day >= 1); - ASSERT (Time->Day <= mDayOfMonth[Time->Month - 1]); - ASSERT (Time->Month != 2 || IsLeapYear (Time) || Time->Day <= 28); - if (Time->Day < 1 || Time->Day > mDayOfMonth[Time->Month - 1] || (Time->Month == 2 && !IsLeapYear (Time) && Time->Day > 28)) { @@ -113,6 +109,7 @@ IsTimeValid( Time->Hour > 23 || Time->Minute > 59 || Time->Second > 59 || + Time->Nanosecond > 999999999 || !IsValidTimeZone (Time->TimeZone) || !IsValidDaylight (Time->Daylight)) { return FALSE; -- 2.39.2