From 33d228aa027bd0944f6a23dbb3c7778fb861e49c Mon Sep 17 00:00:00 2001 From: eric_tian Date: Mon, 10 Aug 2009 06:32:30 +0000 Subject: [PATCH] refine some definitions comments. git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9031 6f19259b-4bc3-4df7-8a09-765794883524 --- .../Framework/FrameworkInternalFormRepresentation.h | 3 ++- .../Include/Protocol/FrameworkFormCallback.h | 8 +++----- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/IntelFrameworkPkg/Include/Framework/FrameworkInternalFormRepresentation.h b/IntelFrameworkPkg/Include/Framework/FrameworkInternalFormRepresentation.h index 925defebf3..a5579c4db2 100644 --- a/IntelFrameworkPkg/Include/Framework/FrameworkInternalFormRepresentation.h +++ b/IntelFrameworkPkg/Include/Framework/FrameworkInternalFormRepresentation.h @@ -279,7 +279,7 @@ typedef struct { /// Inconsistent with specification here: /// Following defintion may not comply with Framework Specification HII 0.92. To /// keep the inconsistant is for implementation needed. -/// +///@{ typedef struct { FRAMEWORK_EFI_IFR_OP_HEADER Header; UINT8 Flags; @@ -323,6 +323,7 @@ typedef struct { UINT16 VariableId; ///< offset into variable storage UINT16 Value; ///< value to compare against } EFI_IFR_EQ_VAR_VAL; +///@} typedef struct { FRAMEWORK_EFI_IFR_OP_HEADER Header; diff --git a/IntelFrameworkPkg/Include/Protocol/FrameworkFormCallback.h b/IntelFrameworkPkg/Include/Protocol/FrameworkFormCallback.h index 82b9bc54bc..67a50d7fe7 100644 --- a/IntelFrameworkPkg/Include/Protocol/FrameworkFormCallback.h +++ b/IntelFrameworkPkg/Include/Protocol/FrameworkFormCallback.h @@ -37,11 +37,9 @@ typedef struct _EFI_FORM_CALLBACK_PROTOCOL EFI_FORM_CALLBACK_PROTOCOL; /// /// Inconsistent with specification here: -/// EFI_IFR_DATA_ENTRY RESET_REQUIRED, EXIT_REQUIRED, SAVE_REQUIRED, NV_CHANGED -//// and NV_NOT_CHANGED are not defined in HII specification. These Flags of EFI_IFR_DATA_ENTRY -/// should be defined to describe the standard behavior of the browser after the callback. -/// - +/// RESET_REQUIRED, EXIT_REQUIRED, SAVE_REQUIRED, NV_CHANGED and NV_NOT_CHANGED are not +/// defined in HII specification. These Flags of EFI_IFR_DATA_ENTRY should be defined +/// to describe the standard behavior of the browser after the callback. /// /// If this flag is set, the browser will exit and reset after processing callback results /// -- 2.39.2