From 3728ea5a95e4321a6fdcec13188b712eba55f4ad Mon Sep 17 00:00:00 2001 From: Laszlo Ersek Date: Wed, 30 Aug 2017 13:31:30 +0200 Subject: [PATCH] OvmfPkg/BaseMemEncryptSevLib: promote DEBUG_WARN levels to DEBUG_ERROR In SetMemoryEncDec(), we have four locations where we (a) log a message on the DEBUG_WARN level that says "ERROR", (b) return the status code RETURN_NO_MAPPING right after. These messages clearly describe actual errors (bad PML4, PDPE, PDE, PTE). Promote their debug levels to DEBUG_ERROR, and remove the word "ERROR" from the messages. Cc: Brijesh Singh Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek Reviewed-by: Brijesh Singh Tested-by: Brijesh Singh --- .../BaseMemEncryptSevLib/X64/VirtualMemory.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c index 58c793dae6..c37d799bc1 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c @@ -287,8 +287,8 @@ SetMemoryEncDec ( PageMapLevel4Entry += PML4_OFFSET(PhysicalAddress); if (!PageMapLevel4Entry->Bits.Present) { DEBUG (( - DEBUG_WARN, - "%a:%a: ERROR bad PML4 for Physical=0x%Lx\n", + DEBUG_ERROR, + "%a:%a: bad PML4 for Physical=0x%Lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress @@ -300,8 +300,8 @@ SetMemoryEncDec ( PageDirectory1GEntry += PDP_OFFSET(PhysicalAddress); if (!PageDirectory1GEntry->Bits.Present) { DEBUG (( - DEBUG_WARN, - "%a:%a: ERROR bad PDPE for Physical=0x%Lx\n", + DEBUG_ERROR, + "%a:%a: bad PDPE for Physical=0x%Lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress @@ -351,8 +351,8 @@ SetMemoryEncDec ( PageDirectory2MEntry += PDE_OFFSET(PhysicalAddress); if (!PageDirectory2MEntry->Bits.Present) { DEBUG (( - DEBUG_WARN, - "%a:%a: ERROR bad PDE for Physical=0x%Lx\n", + DEBUG_ERROR, + "%a:%a: bad PDE for Physical=0x%Lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress @@ -391,8 +391,8 @@ SetMemoryEncDec ( PageTableEntry += PTE_OFFSET(PhysicalAddress); if (!PageTableEntry->Bits.Present) { DEBUG (( - DEBUG_WARN, - "%a:%a: ERROR bad PTE for Physical=0x%Lx\n", + DEBUG_ERROR, + "%a:%a: bad PTE for Physical=0x%Lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress -- 2.39.2