From 37431eb1fedbfbfd3b471d5f599aa90c77d97099 Mon Sep 17 00:00:00 2001 From: "Chasel, Chiu" Date: Wed, 8 Nov 2017 20:35:26 +0800 Subject: [PATCH 1/1] IntelFsp2Pkg-Tools: GenCfgOpt.py shouldn't include specific UPD name PcdSerialIoUartDebugEnable UPD is platform specific and should not be included in generic GenCfgOpt.py script. Remove this and platform DSC should control the default value instead. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chasel Chiu Reviewed-by: Jiewen Yao --- IntelFsp2Pkg/Tools/GenCfgOpt.py | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/IntelFsp2Pkg/Tools/GenCfgOpt.py b/IntelFsp2Pkg/Tools/GenCfgOpt.py index 6dc1b10b34..c9b7bc5373 100644 --- a/IntelFsp2Pkg/Tools/GenCfgOpt.py +++ b/IntelFsp2Pkg/Tools/GenCfgOpt.py @@ -289,7 +289,6 @@ class CGenCfgOpt: def __init__(self): self.Debug = False self.Error = '' - self.ReleaseMode = True self._GlobalDataDef = """ GlobalDataDef @@ -318,13 +317,6 @@ EndList self._FvDir = '' self._MapVer = 0 - def ParseBuildMode (self, OutputStr): - if "RELEASE_" in OutputStr: - self.ReleaseMode = True - if "DEBUG_" in OutputStr: - self.ReleaseMode = False - return - def ParseMacros (self, MacroDefStr): # ['-DABC=1', '-D', 'CFG_DEBUG=1', '-D', 'CFG_OUTDIR=Build'] self._MacroDict = {} @@ -815,9 +807,6 @@ EndList TxtFd.write("%s.UnusedUpdSpace%d|%s0x%04X|0x%04X|{0}\n" % (Item['space'], SpaceIdx, Default, NextOffset - StartAddr, Offset - NextOffset)) SpaceIdx = SpaceIdx + 1 NextOffset = Offset + Item['length'] - if Item['cname'] == 'PcdSerialIoUartDebugEnable': - if self.ReleaseMode == False: - Item['value'] = 0x01 TxtFd.write("%s.%s|%s0x%04X|%s|%s\n" % (Item['space'],Item['cname'],Default,Item['offset'] - StartAddr,Item['length'],Item['value'])) TxtFd.close() return 0 @@ -1437,7 +1426,6 @@ def Main(): print "ERROR: Macro parsing failed !" return 3 - GenCfgOpt.ParseBuildMode(sys.argv[3]) FvDir = sys.argv[3] if not os.path.exists(FvDir): os.makedirs(FvDir) -- 2.39.2