From 399caf2d14b4e933fc1f0050f29d290359ba3614 Mon Sep 17 00:00:00 2001 From: Hao Wu Date: Tue, 11 Oct 2016 15:18:32 +0800 Subject: [PATCH] BaseTools/GenVtf: Fix potential memory leak Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu Reviewed-by: Liming Gao --- BaseTools/Source/C/GenVtf/GenVtf.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/BaseTools/Source/C/GenVtf/GenVtf.c b/BaseTools/Source/C/GenVtf/GenVtf.c index 006822a79b..a61502f315 100644 --- a/BaseTools/Source/C/GenVtf/GenVtf.c +++ b/BaseTools/Source/C/GenVtf/GenVtf.c @@ -1232,11 +1232,13 @@ Returns: Vtf1TotalSize += (UINT32) (FileSize + NumAdjustByte); Status = UpdateVtfBuffer (CompStartAddress, Buffer, FileSize, FIRST_VTF); } else { + free (Buffer); Error (NULL, 0, 2000,"Invalid Parameter", "There's component in second VTF so second BaseAddress and Size must be specified!"); return EFI_INVALID_PARAMETER; } if (EFI_ERROR (Status)) { + free (Buffer); return EFI_ABORTED; } @@ -1248,6 +1250,7 @@ Returns: CompFitPtr->CompAddress = CompStartAddress | IPF_CACHE_BIT; if ((FileSize % 16) != 0) { + free (Buffer); Error (NULL, 0, 2000, "Invalid parameter", "Binary FileSize must be a multiple of 16."); return EFI_INVALID_PARAMETER; } @@ -1389,6 +1392,7 @@ Returns: PalFitPtr->CompAddress = PalStartAddress | IPF_CACHE_BIT; //assert ((FileSize % 16) == 0); if ((FileSize % 16) != 0) { + free (Buffer); Error (NULL, 0, 2000, "Invalid parameter", "Binary FileSize must be a multiple of 16."); return EFI_INVALID_PARAMETER; } -- 2.39.2