From 3abc11f65ef421ca520fa345945418312bcda279 Mon Sep 17 00:00:00 2001 From: Eric Dong Date: Tue, 26 Aug 2014 07:46:38 +0000 Subject: [PATCH] Clean up the framework style code. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong Reviewed-by: Liming, Gao git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15899 6f19259b-4bc3-4df7-8a09-765794883524 --- .../Universal/DriverSampleDxe/Vfr.vfr | 38 ++++++++++--------- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr b/MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr index ee9f7c7dc4..b808abc627 100644 --- a/MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr +++ b/MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr @@ -182,10 +182,10 @@ formset // CHECKBOX_DEFAULT_MFG indicate EFI_IFR_CHECKBOX_DEFAULT_MFG. // flags = CHECKBOX_DEFAULT | CHECKBOX_DEFAULT_MFG, - default = 1, + default = TRUE, endcheckbox; endif; - endif; + endif; // // Ordered list: @@ -206,11 +206,12 @@ formset varid = MyIfrNVData.BootOrder, prompt = STRING_TOKEN(STR_BOOT_OPTIONS), help = STRING_TOKEN(STR_NULL_STRING), - option text = STRING_TOKEN(STR_BOOT_OPTION2), value = 2, flags = RESET_REQUIRED; - option text = STRING_TOKEN(STR_BOOT_OPTION1), value = 1, flags = RESET_REQUIRED; - option text = STRING_TOKEN(STR_BOOT_OPTION3), value = 3, flags = RESET_REQUIRED; + flags = RESET_REQUIRED, + option text = STRING_TOKEN(STR_BOOT_OPTION2), value = 2, flags = 0; + option text = STRING_TOKEN(STR_BOOT_OPTION1), value = 1, flags = 0; + option text = STRING_TOKEN(STR_BOOT_OPTION3), value = 3, flags = 0; suppressif ideqval MyIfrNVData.BootOrderLarge == 0; - option text = STRING_TOKEN(STR_BOOT_OPTION4), value = 4, flags = RESET_REQUIRED; + option text = STRING_TOKEN(STR_BOOT_OPTION4), value = 4, flags = 0; endif endlist; @@ -226,9 +227,10 @@ formset varid = MyIfrNVData.OrderedList, prompt = STRING_TOKEN(STR_TEST_OPCODE), help = STRING_TOKEN(STR_TEXT_HELP), - option text = STRING_TOKEN(STR_ONE_OF_TEXT1), value = 3, flags = RESET_REQUIRED; - option text = STRING_TOKEN(STR_ONE_OF_TEXT2), value = 2, flags = RESET_REQUIRED; - option text = STRING_TOKEN(STR_ONE_OF_TEXT3), value = 1, flags = RESET_REQUIRED; + flags = RESET_REQUIRED, + option text = STRING_TOKEN(STR_ONE_OF_TEXT1), value = 3, flags = 0; + option text = STRING_TOKEN(STR_ONE_OF_TEXT2), value = 2, flags = 0; + option text = STRING_TOKEN(STR_ONE_OF_TEXT3), value = 1, flags = 0; endlist; endif; @@ -252,8 +254,9 @@ formset oneof varid = MyIfrNVData.TestLateCheck, prompt = STRING_TOKEN(STR_TEST_OPCODE), help = STRING_TOKEN(STR_ONE_OF_HELP), - option text = STRING_TOKEN(STR_ONE_OF_TEXT1), value = 0, flags = RESET_REQUIRED; - option text = STRING_TOKEN(STR_ONE_OF_TEXT2), value = 1, flags = DEFAULT | RESET_REQUIRED; + flags = RESET_REQUIRED, + option text = STRING_TOKEN(STR_ONE_OF_TEXT1), value = 0, flags = 0; + option text = STRING_TOKEN(STR_ONE_OF_TEXT2), value = 1, flags = DEFAULT; warningif prompt = STRING_TOKEN(STR_WARNING_POPUP), timeout = 5, ideqval MyIfrNVData.TestLateCheck == 0 endif @@ -263,8 +266,9 @@ formset oneof varid = MyIfrNVData.TestLateCheck2, prompt = STRING_TOKEN(STR_TEST_OPCODE2), help = STRING_TOKEN(STR_ONE_OF_HELP), - option text = STRING_TOKEN(STR_ONE_OF_TEXT1), value = 0, flags = DEFAULT | RESET_REQUIRED; - option text = STRING_TOKEN(STR_ONE_OF_TEXT2), value = 1, flags = RESET_REQUIRED; + flags = RESET_REQUIRED, + option text = STRING_TOKEN(STR_ONE_OF_TEXT1), value = 0, flags = DEFAULT; + option text = STRING_TOKEN(STR_ONE_OF_TEXT2), value = 1, flags = 0; inconsistentif prompt = STRING_TOKEN(STR_ERROR_POPUP), ideqid MyIfrNVData.TestLateCheck == MyIfrNVData.TestLateCheck2 @@ -275,10 +279,10 @@ formset oneof varid = MyIfrNVData.QuestionAboutTreeHugging, prompt = STRING_TOKEN(STR_ONE_OF_PROMPT), help = STRING_TOKEN(STR_ONE_OF_HELP), - option text = STRING_TOKEN(STR_ONE_OF_TEXT1), value = 0, flags = RESET_REQUIRED; - option text = STRING_TOKEN(STR_ONE_OF_TEXT2), value = 1, flags = DEFAULT | RESET_REQUIRED; - option text = STRING_TOKEN(STR_ONE_OF_TEXT3), value = 0x03, flags = RESET_REQUIRED; - + flags = RESET_REQUIRED, + option text = STRING_TOKEN(STR_ONE_OF_TEXT1), value = 0, flags = 0; + option text = STRING_TOKEN(STR_ONE_OF_TEXT2), value = 1, flags = DEFAULT; + option text = STRING_TOKEN(STR_ONE_OF_TEXT3), value = 3, flags = 0; endoneof; // -- 2.39.2