From 43fe4c4052922c6baa36cf4664ce63b8699d9176 Mon Sep 17 00:00:00 2001 From: Jaben Carsey Date: Sat, 18 Aug 2018 00:17:40 +0800 Subject: [PATCH] BaseTools: remove unused setter functions Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey Reviewed-by: Yonghong Zhu --- .../Source/Python/Workspace/DecBuildData.py | 17 +---------- .../Source/Python/Workspace/DscBuildData.py | 17 +---------- .../Source/Python/Workspace/InfBuildData.py | 30 ++----------------- 3 files changed, 4 insertions(+), 60 deletions(-) diff --git a/BaseTools/Source/Python/Workspace/DecBuildData.py b/BaseTools/Source/Python/Workspace/DecBuildData.py index 7eeca95245..45beaebc63 100644 --- a/BaseTools/Source/Python/Workspace/DecBuildData.py +++ b/BaseTools/Source/Python/Workspace/DecBuildData.py @@ -116,21 +116,6 @@ class DecBuildData(PackageBuildClassObject): def _GetArch(self): return self._Arch - ## Set architecture - # - # Changing the default ARCH to another may affect all other information - # because all information in a platform may be ARCH-related. That's - # why we need to clear all internal used members, in order to cause all - # information to be re-retrieved. - # - # @param Value The value of ARCH - # - def _SetArch(self, Value): - if self._Arch == Value: - return - self._Arch = Value - self._Clear() - ## Retrieve all information in [Defines] section # # (Retriving all [Defines] information in one-shot is just to save time.) @@ -469,7 +454,7 @@ class DecBuildData(PackageBuildClassObject): _Macros = property(_GetMacros) - Arch = property(_GetArch, _SetArch) + Arch = property(_GetArch) PackageName = property(_GetPackageName) Guid = property(_GetFileGuid) Version = property(_GetVersion) diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py index c7f07f4646..a4ad53ee15 100644 --- a/BaseTools/Source/Python/Workspace/DscBuildData.py +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py @@ -308,21 +308,6 @@ class DscBuildData(PlatformBuildClassObject): def _GetArch(self): return self._Arch - ## Set architecture - # - # Changing the default ARCH to another may affect all other information - # because all information in a platform may be ARCH-related. That's - # why we need to clear all internal used members, in order to cause all - # information to be re-retrieved. - # - # @param Value The value of ARCH - # - def _SetArch(self, Value): - if self._Arch == Value: - return - self._Arch = Value - self._Clear() - ## Retrieve all information in [Defines] section # # (Retriving all [Defines] information in one-shot is just to save time.) @@ -2849,7 +2834,7 @@ class DscBuildData(PlatformBuildClassObject): self._DecPcds, self._GuidDict = GetDeclaredPcd(self, self._Bdb, self._Arch, self._Target, self._Toolchain, PkgSet) return self._DecPcds _Macros = property(_GetMacros) - Arch = property(_GetArch, _SetArch) + Arch = property(_GetArch) Platform = property(_GetPlatformName) PlatformName = property(_GetPlatformName) Guid = property(_GetFileGuid) diff --git a/BaseTools/Source/Python/Workspace/InfBuildData.py b/BaseTools/Source/Python/Workspace/InfBuildData.py index 44eaebf62e..7c3d712efe 100644 --- a/BaseTools/Source/Python/Workspace/InfBuildData.py +++ b/BaseTools/Source/Python/Workspace/InfBuildData.py @@ -173,36 +173,10 @@ class InfBuildData(ModuleBuildClassObject): def _GetArch(self): return self._Arch - ## Set architecture - # - # Changing the default ARCH to another may affect all other information - # because all information in a platform may be ARCH-related. That's - # why we need to clear all internal used members, in order to cause all - # information to be re-retrieved. - # - # @param Value The value of ARCH - # - def _SetArch(self, Value): - if self._Arch == Value: - return - self._Arch = Value - self._Clear() - ## Return the name of platform employing this module def _GetPlatform(self): return self._Platform - ## Change the name of platform employing this module - # - # Changing the default name of platform to another may affect some information - # because they may be PLATFORM-related. That's why we need to clear all internal - # used members, in order to cause all information to be re-retrieved. - # - def _SetPlatform(self, Value): - if self._Platform == Value: - return - self._Platform = Value - self._Clear() def _GetHeaderComments(self): if not self._HeaderComments: self._HeaderComments = [] @@ -1154,8 +1128,8 @@ class InfBuildData(ModuleBuildClassObject): return False _Macros = property(_GetMacros) - Arch = property(_GetArch, _SetArch) - Platform = property(_GetPlatform, _SetPlatform) + Arch = property(_GetArch) + Platform = property(_GetPlatform) HeaderComments = property(_GetHeaderComments) TailComments = property(_GetTailComments) -- 2.39.2