From 44d1d2a828617dd7373823cb7120e80d0b9ce787 Mon Sep 17 00:00:00 2001 From: "Yao, Jiewen" Date: Thu, 17 Dec 2015 14:06:52 +0000 Subject: [PATCH] Add clarification for PcdAcpiDefault value PCD. Add clarification for PcdAcpiDefaultOemTableId, PcdAcpiDefaultOemRevision, PcdAcpiDefaultCreatorId, PcdAcpiDefaultCreatorRevision. According to ACPI spec, they are used as special meaning for SSDT, so we ignore them in updating generic SSDT provided by EDKII. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Reviewed-by: "Zeng, Star" com> git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19321 6f19259b-4bc3-4df7-8a09-765794883524 --- MdeModulePkg/MdeModulePkg.dec | 14 ++++++++++++++ MdeModulePkg/MdeModulePkg.uni | 22 ++++++++++++++++++---- 2 files changed, 32 insertions(+), 4 deletions(-) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 5ec37c5a7d..e2e0b75cdb 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -1408,18 +1408,32 @@ gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemId|"INTEL "|VOID*|0x30001034 ## Default OEM Table ID for ACPI table creation, it is "EDK2 ". + # Accroding to ACPI specification, this field is particularly useful when + # defining a definition block to distinguish definition block functions. + # The OEM assigns each dissimilar table a new OEM Table ID. + # This PCD is ignored for definition block. # @Prompt Default OEM Table ID for ACPI table creation. gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemTableId|0x20202020324B4445|UINT64|0x30001035 ## Default OEM Revision for ACPI table creation. + # Accroding to ACPI specification, for LoadTable() opcode, the OS can also + # check the OEM Table ID and Revision ID against a database for a newer + # revision Definition Block of the same OEM Table ID and load it instead. + # This PCD is ignored for definition block. # @Prompt Default OEM Revision for ACPI table creation. gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemRevision|0x00000002|UINT32|0x30001036 ## Default Creator ID for ACPI table creation. + # Accroding to ACPI specification, for tables containing Definition Blocks, + # this is the ID for the ASL Compiler. + # This PCD is ignored for definition block. # @Prompt Default Creator ID for ACPI table creation. gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorId|0x20202020|UINT32|0x30001037 ## Default Creator Revision for ACPI table creation. + # Accroding to ACPI specification, for tables containing Definition Blocks, + # this is the revision for the ASL Compiler. + # This PCD is ignored for definition block. # @Prompt Default Creator Revision for ACPI table creation. gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorRevision|0x01000013|UINT32|0x30001038 diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni index 7ef7d910bf..c026f14534 100644 --- a/MdeModulePkg/MdeModulePkg.uni +++ b/MdeModulePkg/MdeModulePkg.uni @@ -225,19 +225,33 @@ #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdAcpiDefaultOemTableId_PROMPT #language en-US "Default OEM Table ID for ACPI table creation" -#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdAcpiDefaultOemTableId_HELP #language en-US "Default OEM Table ID for ACPI table creation." +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdAcpiDefaultOemTableId_HELP #language en-US "Default OEM Table ID for ACPI table creation.

\n" + "Accroding to ACPI specification, this field is particularly useful when\n" + "defining a definition block to distinguish definition block functions.
\n" + "The OEM assigns each dissimilar table a new OEM Table ID.
\n" + "This PCD is ignored for definition block.
" #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdAcpiDefaultOemRevision_PROMPT #language en-US "Default OEM Revision for ACPI table creation" -#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdAcpiDefaultOemRevision_HELP #language en-US "Default OEM Revision for ACPI table creation." +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdAcpiDefaultOemRevision_HELP #language en-US "Default OEM Revision for ACPI table creation.

\n" + "Accroding to ACPI specification, for LoadTable() opcode, the OS can also\n" + "check the OEM Table ID and Revision ID against a database for a newer\n" + "revision Definition Block of the same OEM Table ID and load it instead.
\n" + "This PCD is ignored for definition block.
" #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdAcpiDefaultCreatorId_PROMPT #language en-US "Default Creator ID for ACPI table creation" -#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdAcpiDefaultCreatorId_HELP #language en-US "Default Creator ID for ACPI table creation." +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdAcpiDefaultCreatorId_HELP #language en-US "Default Creator ID for ACPI table creation.

\n" + "Accroding to ACPI specification, for tables containing Definition Blocks,\n" + "this is the ID for the ASL Compiler.
\n" + "This PCD is ignored for definition block.
" #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdAcpiDefaultCreatorRevision_PROMPT #language en-US "Default Creator Revision for ACPI table creation" -#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdAcpiDefaultCreatorRevision_HELP #language en-US "Default Creator Revision for ACPI table creation." +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdAcpiDefaultCreatorRevision_HELP #language en-US "Default Creator Revision for ACPI table creation.

\n" + "Accroding to ACPI specification, for tables containing Definition Blocks,\n" + "this is the revision for the ASL Compiler.
\n" + "This PCD is ignored for definition block.
" #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdMemoryProfilePropertyMask_PROMPT #language en-US "Memory Profile Property" -- 2.39.2