From 5a119220c1c11e0dce5cc6ef1b3fa8eaef4b3d8e Mon Sep 17 00:00:00 2001 From: Krzysztof Koch Date: Fri, 28 Jun 2019 16:56:57 +0800 Subject: [PATCH] ShellPkg: acpiview: Fix '\n\n' printing in Table Checksum reporting Move printing double newline character ('\n\n') from the beginning of ACPI table checksum validation message to the end of the raw binary data dump. This way acpiview table dump looks similar regardless of whether Table Checksum is validated or not. Signed-off-by: Krzysztof Koch Reviewed-by: Alexei Fedorov Reviewed-by: Zhichao Gao Reviewed-by: Sami Mujawar --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c index b5965507b4..f9dbbd3544 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c @@ -1,7 +1,7 @@ /** @file ACPI parser - Copyright (c) 2016 - 2018, ARM Limited. All rights reserved. + Copyright (c) 2016 - 2019, ARM Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -139,7 +139,7 @@ VerifyChecksum ( ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4)) ); } - Print (L"\n\nTable Checksum : OK\n\n"); + Print (L"Table Checksum : OK\n\n"); } else { IncrementErrorCount (); if (GetColourHighlighting ()) { @@ -149,7 +149,7 @@ VerifyChecksum ( ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4)) ); } - Print (L"\n\nTable Checksum : FAILED (0x%X)\n\n", Checksum); + Print (L"Table Checksum : FAILED (0x%X)\n\n", Checksum); } if (GetColourHighlighting ()) { gST->ConOut->SetAttribute (gST->ConOut, OriginalAttribute); @@ -219,7 +219,7 @@ DumpRaw ( // Print ASCII data for the final line. AsciiBuffer[AsciiBufferIndex] = '\0'; - Print (L" %a", AsciiBuffer); + Print (L" %a\n\n", AsciiBuffer); } /** -- 2.39.2