From 5fe292b42fa6e0066fdb1f9a98fdfb3f52ffcbd0 Mon Sep 17 00:00:00 2001 From: Jordan Justen Date: Thu, 24 Jul 2014 18:15:13 -0700 Subject: [PATCH] MdePkg BaseLib Ia32 assembly: Specify DWORD sizes NASM wants this code to specify a size. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen Cc: Michael D Kinney Cc: Liming Gao --- MdePkg/Library/BaseLib/Ia32/CpuId.asm | 2 +- MdePkg/Library/BaseLib/Ia32/CpuIdEx.asm | 2 +- MdePkg/Library/BaseLib/Ia32/EnablePaging64.asm | 2 +- MdePkg/Library/BaseLib/Ia32/SetJump.asm | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/MdePkg/Library/BaseLib/Ia32/CpuId.asm b/MdePkg/Library/BaseLib/Ia32/CpuId.asm index 0141cb2ca4..a1a01c0600 100644 --- a/MdePkg/Library/BaseLib/Ia32/CpuId.asm +++ b/MdePkg/Library/BaseLib/Ia32/CpuId.asm @@ -52,7 +52,7 @@ AsmCpuid PROC USES ebx @@: mov ecx, [ebp + 24] jecxz @F - pop [ecx] + pop DWORD [ecx] @@: mov ecx, [ebp + 28] jecxz @F diff --git a/MdePkg/Library/BaseLib/Ia32/CpuIdEx.asm b/MdePkg/Library/BaseLib/Ia32/CpuIdEx.asm index 504b397f1f..9cca11b752 100644 --- a/MdePkg/Library/BaseLib/Ia32/CpuIdEx.asm +++ b/MdePkg/Library/BaseLib/Ia32/CpuIdEx.asm @@ -58,7 +58,7 @@ AsmCpuidEx PROC USES ebx @@: mov ecx, [ebp + 28] jecxz @F - pop [ecx] + pop DWORD [ecx] @@: mov eax, [ebp + 12] leave diff --git a/MdePkg/Library/BaseLib/Ia32/EnablePaging64.asm b/MdePkg/Library/BaseLib/Ia32/EnablePaging64.asm index 5cc1d6baf2..9ad3404945 100644 --- a/MdePkg/Library/BaseLib/Ia32/EnablePaging64.asm +++ b/MdePkg/Library/BaseLib/Ia32/EnablePaging64.asm @@ -38,7 +38,7 @@ ;------------------------------------------------------------------------------ InternalX86EnablePaging64 PROC cli - mov [esp], @F ; offset for far retf, seg is the 1st arg + mov DWORD PTR [esp], @F ; offset for far retf, seg is the 1st arg mov eax, cr4 or al, (1 SHL 5) mov cr4, eax ; enable PAE diff --git a/MdePkg/Library/BaseLib/Ia32/SetJump.asm b/MdePkg/Library/BaseLib/Ia32/SetJump.asm index 8486b9f5b8..0bfa404cf4 100644 --- a/MdePkg/Library/BaseLib/Ia32/SetJump.asm +++ b/MdePkg/Library/BaseLib/Ia32/SetJump.asm @@ -33,7 +33,7 @@ InternalAssertJumpBuffer PROTO C ; ); ;------------------------------------------------------------------------------ SetJump PROC - push [esp + 4] + push DWORD [esp + 4] call InternalAssertJumpBuffer ; To validate JumpBuffer pop ecx pop ecx ; ecx <- return address -- 2.39.2