From 6a497016c9f6aa60e9be330d1592f8b5e71156ef Mon Sep 17 00:00:00 2001 From: Chris Ruffin Date: Thu, 18 Dec 2014 06:13:36 +0000 Subject: [PATCH] MdeModulePkg\Bus\Ata\AtaAtapiPassThru: don't set PxSACT bit when issuing command Setting a bit in the PxSACT register for a command in the command list indicates to the controller that the command list slot contains a native queued command (NCQ). This can cause problems with some controllers (one such controller is the Marvell 9128). Since NCQ commands are not used, don't set the PxACT register for commands issued. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chris Ruffin Reviewed-by: Feng Tian git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16536 6f19259b-4bc3-4df7-8a09-765794883524 --- MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c index 186d40c062..4d1b5848a5 100644 --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c @@ -1340,10 +1340,6 @@ AhciStartCommand ( // // Setting the command // - Offset = EFI_AHCI_PORT_START + Port * EFI_AHCI_PORT_REG_WIDTH + EFI_AHCI_PORT_SACT; - AhciAndReg (PciIo, Offset, 0); - AhciOrReg (PciIo, Offset, CmdSlotBit); - Offset = EFI_AHCI_PORT_START + Port * EFI_AHCI_PORT_REG_WIDTH + EFI_AHCI_PORT_CI; AhciAndReg (PciIo, Offset, 0); AhciOrReg (PciIo, Offset, CmdSlotBit); -- 2.39.2