From 7cac2401635317360226a235d1f95f8347081cbb Mon Sep 17 00:00:00 2001 From: Feng Tian Date: Thu, 7 Jan 2016 07:03:32 +0000 Subject: [PATCH 1/1] MdeModulePkg/Ide: return correct status when DRQ is not ready for ATAPI When executing ATAPI cmd at IDE mode, EFI_SUCCESS may be returned wrongly with old logic but in fact DRQ is not ready and the transaction doesn't get executed correctly at this time. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian Reviewed-by: Star Zeng git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19611 6f19259b-4bc3-4df7-8a09-765794883524 --- MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c index 4928ed570b..f74e5ca373 100644 --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c @@ -1949,7 +1949,7 @@ AtaPacketReadWrite ( // Status = DRQReady2 (PciIo, IdeRegisters, Timeout); if (EFI_ERROR (Status)) { - return CheckStatusRegister (PciIo, IdeRegisters); + return Status; } // -- 2.39.2