From 8d0776f3e60482ed621e45b2b52db8a604d7e5a2 Mon Sep 17 00:00:00 2001 From: Charles Duffy Date: Wed, 20 Jan 2016 05:15:55 +0000 Subject: [PATCH] BaseTools: Improve LzmaF86Compress wrapper - Remove test usage declared obsolescent by POSIX - Pass argv array through as literal rather than forming into a string, then string-splitting and glob-expanding same. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Charles Duffy Reviewed-by: Yonghong Zhu git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19697 6f19259b-4bc3-4df7-8a09-765794883524 --- BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaF86Compress | 15 ++++++++------- BaseTools/BinWrappers/PosixLike/LzmaF86Compress | 15 ++++++++------- 2 files changed, 16 insertions(+), 14 deletions(-) diff --git a/BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaF86Compress b/BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaF86Compress index c3e49cf29d..50af530cbd 100755 --- a/BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaF86Compress +++ b/BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaF86Compress @@ -12,11 +12,12 @@ # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. # -for arg in $*; do - if [ "arg" = "-e" -o "arg" = "-d" ]; then - FLAG=--f86 - break; - fi -done +for arg; do + case $arg in + -e|-d) + set -- "$@" --f86 + break + ;; +esac -LzmaCompress $* $FLAG +exec LzmaCompress "$@" diff --git a/BaseTools/BinWrappers/PosixLike/LzmaF86Compress b/BaseTools/BinWrappers/PosixLike/LzmaF86Compress index 18946a4d2d..50af530cbd 100755 --- a/BaseTools/BinWrappers/PosixLike/LzmaF86Compress +++ b/BaseTools/BinWrappers/PosixLike/LzmaF86Compress @@ -12,11 +12,12 @@ # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. # -for arg in $*; do - if [ "$arg" = "-e" -o "$arg" = "-d" ]; then - FLAG=--f86 - break; - fi -done +for arg; do + case $arg in + -e|-d) + set -- "$@" --f86 + break + ;; +esac -LzmaCompress $* $FLAG +exec LzmaCompress "$@" -- 2.39.2