From 92ab049719afe96913c0452bcf12946e0af0f0d5 Mon Sep 17 00:00:00 2001 From: "Ni, Ray" Date: Wed, 15 Jun 2022 12:54:39 +0800 Subject: [PATCH] BaseTools: output the intermediate library instance when error occurs When a module "Module" depends on a library instance "Lib1" which depends on "Lib2" which depends on "Lib3" ... depends on "LibN", but "LibN" doesn't support the type (e.g.: SEC) of the "Module", the following error messages are printed by build tool: (...): error 1001: Module by library instance [] consumed by [] But it's unclear to user how LibN is consumed by the Module. With the patch, following errors are printed: (...): error 1001: Module by library instance [] consumed by library instance [] which is consumed by module[] It doesn't print all the intermediate library instances between the Module and LibN but at least the path of Lib N-1 can help users to help how to fix the build errors. I hope this patch can be a trigger point that a better solution could be developed by tool experts to print all the library instances between the Module and LibN. Signed-off-by: Ray Ni Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Reviewed-by: Bob Feng --- BaseTools/Source/Python/Workspace/WorkspaceCommon.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/Workspace/WorkspaceCommon.py b/BaseTools/Source/Python/Workspace/WorkspaceCommon.py index 53027a0e30..9e506fc646 100644 --- a/BaseTools/Source/Python/Workspace/WorkspaceCommon.py +++ b/BaseTools/Source/Python/Workspace/WorkspaceCommon.py @@ -150,7 +150,9 @@ def GetModuleLibInstances(Module, Platform, BuildDatabase, Arch, Target, Toolcha EdkLogger.error("build", OPTION_MISSING, "Module type [%s] is not supported by library instance [%s]" \ % (ModuleType, LibraryPath), File=FileName, - ExtraData="consumed by [%s]" % str(Module)) + ExtraData="consumed by library instance [%s] which is consumed by module [%s]" \ + % (str(M), str(Module)) + ) else: return [] -- 2.39.2