From 9d1c98e699af96ea5e4caf2610e18bf5e97dda3b Mon Sep 17 00:00:00 2001 From: Fu Siyuan Date: Tue, 2 Jan 2018 13:18:17 +0800 Subject: [PATCH] NetworkPkg: Add assert for buffer pointer from DHCP driver. The PxeBcDhcp4CallBack() is provided for DHCP driver to invoke packet check during DHCP process, the DHCP driver should make sure Packet and NewPacket has meaningful value. This patch adds assert for this. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan Reviewed-by: Sriram Subramanian Reviewed-by: Jiaxin Wu --- NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c index 9c33835759..b2c03eb269 100644 --- a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c +++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c @@ -1210,6 +1210,8 @@ PxeBcDhcp4CallBack ( return EFI_SUCCESS; } + ASSERT (Packet != NULL); + Private = (PXEBC_PRIVATE_DATA *) Context; Mode = Private->PxeBc.Mode; Callback = Private->PxeBcCallback; @@ -1305,6 +1307,8 @@ PxeBcDhcp4CallBack ( break; case Dhcp4SelectOffer: + ASSERT (NewPacket != NULL); + // // Select offer by the default policy or by order, and record the SelectIndex // and SelectProxyType. -- 2.39.2