From aa75965349875f8c68b0c43b55b0c5e4799c1289 Mon Sep 17 00:00:00 2001 From: Liming Gao Date: Mon, 15 Mar 2021 10:55:47 +0800 Subject: [PATCH] MdeModulePkg: Initialize local variable value before they are used BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3228 This change is to fix the false compiler error on GCC49 release build. Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Liming Gao Reviewed-by: Hao A Wu Reviewed-by: Laszlo Ersek --- MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 5 +++++ .../VariablePolicyHelperLib/VariablePolicyHelperLib.c | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c index e99a812a44..1053695b3b 100644 --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c @@ -1127,6 +1127,11 @@ AhciDmaTransfer ( return EFI_INVALID_PARAMETER; } + // + // Set Status to suppress incorrect compiler/analyzer warnings + // + Status = EFI_SUCCESS; + // // DMA buffer allocation. Needs to be done only once for both sync and async // DMA transfers irrespective of number of retries. diff --git a/MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c b/MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c index 0c9299c8b0..6bcb95247f 100644 --- a/MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c +++ b/MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c @@ -115,6 +115,11 @@ CreateBasicVariablePolicy ( return EFI_INVALID_PARAMETER; } + // + // Set NameSize to suppress incorrect compiler/analyzer warnings + // + NameSize = 0; + // Now we've gotta determine the total size of the buffer required for // the VariablePolicy structure. TotalSize = sizeof( VARIABLE_POLICY_ENTRY ); -- 2.39.2