From b522ca0cf5ab1f272fcfb7f20b487d47bbf480c4 Mon Sep 17 00:00:00 2001 From: "Zhang, Lubo" Date: Fri, 8 Jul 2016 15:50:46 +0800 Subject: [PATCH] NetworkPkg: Fix Assert issue in iSCSI driver. The bug existed in replacing AsciiStrToUnicodeStr with AsciiStrToUnicodeStrS, since MacString now is a pointer, the value sizeof(MacString)/sizeof (MacString[0]) is not correct here as the third parameter. Cc: Fu Siyuan Cc: Ye Ting Cc: Wu Jiaxin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo Reviewed-By: Wu Jiaxin Reviewed-by: Ye Ting Reviewed-by: Fu Siyuan Reviewed-by: Star Zeng --- NetworkPkg/IScsiDxe/IScsiConfig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NetworkPkg/IScsiDxe/IScsiConfig.c b/NetworkPkg/IScsiDxe/IScsiConfig.c index 8015e3de53..3631e72e34 100644 --- a/NetworkPkg/IScsiDxe/IScsiConfig.c +++ b/NetworkPkg/IScsiDxe/IScsiConfig.c @@ -687,7 +687,7 @@ IScsiConvertIfrNvDataToAttemptConfigData ( return EFI_OUT_OF_RESOURCES; } - AsciiStrToUnicodeStrS (Attempt->MacString, MacString, sizeof (MacString) / sizeof (MacString[0])); + AsciiStrToUnicodeStrS (Attempt->MacString, MacString, ISCSI_MAX_MAC_STRING_LEN); UnicodeSPrint ( mPrivate->PortString, -- 2.39.2