From b5bd3ed64898db1088a9468446a0d2d0dc7185e8 Mon Sep 17 00:00:00 2001 From: Vladimir Olovyannikov Date: Thu, 26 Jul 2018 03:47:49 +0800 Subject: [PATCH] MdeModulePkg FvSimpleFileSystemDxe: Fix memory leak in Read function FvSimpleFileSystem on read always allocates a FileBuffer, and never frees it. This causes memory leaks. It is especially bad for reading scripts line-by-line. In some cases memory leak can exceed 1GB. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vladimir Olovyannikiov Reviewed-by: Star Zeng --- .../Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c b/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c index 746f2ced70..fde2085947 100644 --- a/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c +++ b/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c @@ -704,6 +704,7 @@ FvSimpleFileSystemRead ( Status = FvFsReadFile (File->Instance->FvProtocol, File->FvFileInfo, &FileSize, &FileBuffer); if (EFI_ERROR (Status)) { + FreePool (FileBuffer); return EFI_DEVICE_ERROR; } @@ -714,6 +715,8 @@ FvSimpleFileSystemRead ( CopyMem (Buffer, (UINT8*)FileBuffer + File->Position, *BufferSize); File->Position += *BufferSize; + FreePool (FileBuffer); + return EFI_SUCCESS; } } -- 2.39.2