From b6bc203375b6efb6822ee4fe4a59be4f1918436b Mon Sep 17 00:00:00 2001 From: Wenyi Xie Date: Thu, 26 Aug 2021 09:16:03 +0800 Subject: [PATCH] MdeModulePkg/HiiDatabaseDxe:remove dead code block As the if statement outside has confirmed that BlockData->Name == NULL, so the if statement inside is always false. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Eric Dong Signed-off-by: Wenyi Xie Reviewed-by: Dandan Bi --- MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c index d492b769d5..17a914208c 100644 --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c @@ -2871,9 +2871,6 @@ ParseIfrData ( // if ((BlockData->Name == NULL) && ((BlockData->Offset + BlockData->Width) > VarStorageData->Size)) { Status = EFI_INVALID_PARAMETER; - if (BlockData->Name != NULL) { - FreePool (BlockData->Name); - } FreePool (BlockData); goto Done; } -- 2.39.2