From b90ffb9fc8360345138f50988a8a1bd339f80da1 Mon Sep 17 00:00:00 2001 From: Laszlo Ersek Date: Thu, 6 Nov 2014 14:21:09 +0000 Subject: [PATCH 1/1] OvmfPkg: BDS: drop superfluous "connect first boot option" logic This is again obviated by our earlier BdsLibConnectAll() call. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Jordan Justen git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16309 6f19259b-4bc3-4df7-8a09-765794883524 --- OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c | 23 -------------------- 1 file changed, 23 deletions(-) diff --git a/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c b/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c index 9fa48c98d0..e974d3fbc7 100644 --- a/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c +++ b/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c @@ -1063,8 +1063,6 @@ Returns: EFI_STATUS Status; UINT16 Timeout; EFI_EVENT UserInputDurationTime; - LIST_ENTRY *Link; - BDS_COMMON_OPTION *BootOption; UINTN Index; EFI_INPUT_KEY Key; EFI_TPL OldTpl; @@ -1158,27 +1156,6 @@ Returns: // // To give the User a chance to enter Setup here, if user set TimeOut is 0. // BDS should still give user a chance to enter Setup - // - // Connect first boot option, and then check user input before exit - // - for (Link = BootOptionList->ForwardLink; Link != BootOptionList;Link = Link->ForwardLink) { - BootOption = CR (Link, BDS_COMMON_OPTION, Link, BDS_LOAD_OPTION_SIGNATURE); - if (!IS_LOAD_OPTION_TYPE (BootOption->Attribute, LOAD_OPTION_ACTIVE)) { - // - // skip the header of the link list, becuase it has no boot option - // - continue; - } else { - // - // Make sure the boot option device path connected, but ignore the BBS device path - // - if (DevicePathType (BootOption->DevicePath) != BBS_DEVICE_PATH) { - BdsLibConnectDevicePath (BootOption->DevicePath); - } - break; - } - } - // // Check whether the user input after the duration time has expired // -- 2.39.2