From badb54ab92ec4c7c529e5817ade689c902a4fc3e Mon Sep 17 00:00:00 2001 From: rsun3 Date: Thu, 2 Jul 2009 05:58:27 +0000 Subject: [PATCH] code clean up for Security.h. 1. Incorrect comment style preceding _EFI_PEI_SECURITY_PPI. The comments in the file have the format used to describe a function, and should have the format for a structure. 2. Latest PEI CIS (0.91) indicates the param should be: IN OUT BOOLEAN *DeferExecution whereas in the H file it's: IN OUT BOOLEAN *StartCrisisRecovery git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8719 6f19259b-4bc3-4df7-8a09-765794883524 --- IntelFrameworkPkg/Include/Ppi/Security.h | 34 +++++++++--------------- 1 file changed, 12 insertions(+), 22 deletions(-) diff --git a/IntelFrameworkPkg/Include/Ppi/Security.h b/IntelFrameworkPkg/Include/Ppi/Security.h index 44b48d6058..48a99a84cc 100644 --- a/IntelFrameworkPkg/Include/Ppi/Security.h +++ b/IntelFrameworkPkg/Include/Ppi/Security.h @@ -38,16 +38,14 @@ typedef struct _EFI_PEI_SECURITY_PPI EFI_PEI_SECURITY_PPI; Allows the platform builder to implement a security policy in response to varying file authentication states. - @param PeiServices Pointer to the PEI Services Table. - @param This Interface pointer that implements the particular EFI_PEI_SECURITY_PPI instance. - @param AuthenticationStatus - Status returned by the verification service as part of section extraction. - @param FfsFileHeader Pointer to the file under review. - @param DeferExecution Pointer to a variable that alerts the PEI Foundation to defer execution of a PEIM. - - @retval EFI_SUCCESS The service performed its action successfully. - @retval EFI_SECURITY_VIOLATION The object cannot be trusted - + @param PeiServices Pointer to the PEI Services Table. + @param This Interface pointer that implements the particular EFI_PEI_SECURITY_PPI instance. + @param AuthenticationStatus Status returned by the verification service as part of section extraction. + @param FfsFileHeader Pointer to the file under review. + @param DeferExecution Pointer to a variable that alerts the PEI Foundation to defer execution of a PEIM. + + @retval EFI_SUCCESS The service performed its action successfully. + @retval EFI_SECURITY_VIOLATION The object cannot be trusted **/ typedef EFI_STATUS @@ -56,20 +54,12 @@ EFI_STATUS IN EFI_PEI_SECURITY_PPI *This, IN UINT32 AuthenticationStatus, IN EFI_FFS_FILE_HEADER *FfsFileHeader, - IN OUT BOOLEAN *StartCrisisRecovery + IN OUT BOOLEAN *DeferExecution ); -/** - @par Ppi Description: - This PPI is installed by some platform PEIM that abstracts the security - policy to the PEI Foundation, namely the case of a PEIM's authentication - state being returned during the PEI section extraction process. - - @param AuthenticationState - Allows the platform builder to implement a security policy in response - to varying file authentication states. - -**/ +// +// PPI interface structure of Security PPI +// struct _EFI_PEI_SECURITY_PPI { EFI_PEI_SECURITY_AUTHENTICATION_STATE AuthenticationState; }; -- 2.39.2