From bbb5b0d648d918c83f2f99b02e3446787dbe474f Mon Sep 17 00:00:00 2001 From: "Kubacki, Michael A" Date: Fri, 22 Nov 2019 07:02:35 +0800 Subject: [PATCH] MdeModulePkg/Variable: Initialize local variable "Variable" REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2364 Fixes a new build warning in VS2012 introduced in f8ff4cca7c. This patch initializes the local variable "Variable" in VariableServiceGetNextVariableInternal (). This ensures the pointers in the structure are initialized in the case no variable stores exist in the list of variable stores. Cc: Liming Gao Cc: Michael D Kinney Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Michael Kubacki Reviewed-by: Liming Gao Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Jian J Wang --- MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c index d458f1c608..f6d187543d 100644 --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c @@ -551,6 +551,8 @@ VariableServiceGetNextVariableInternal ( return EFI_INVALID_PARAMETER; } + ZeroMem (&Variable, sizeof (Variable)); + // Check if the variable exists in the given variable store list for (StoreType = (VARIABLE_STORE_TYPE) 0; StoreType < VariableStoreTypeMax; StoreType++) { if (VariableStoreList[StoreType] == NULL) { -- 2.39.2