From cf2ddcf13369af2aa98231dae5143e8bab06a00c Mon Sep 17 00:00:00 2001 From: Hao Wu Date: Wed, 16 Nov 2016 15:47:55 +0800 Subject: [PATCH] SignedCapsulePkg IniParsingLib: ASSERT to ensure 'Value' is not NULL Function GetStringFromDataFile() ensures its fourth (output) parameter will not be NULL when the return status is EFI_SUCCESS. This commit adds ASSERT as warnings for the case that will not happen. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu Reviewed-by: Jiewen Yao --- SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c b/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c index a8773c1a80..5c975f7ca4 100644 --- a/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c +++ b/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c @@ -1257,6 +1257,7 @@ GetGuidFromDataFile ( if (EFI_ERROR(Status)) { return EFI_NOT_FOUND; } + ASSERT (Value != NULL); if (!IsValidGuid(Value, AsciiStrLen(Value))) { return EFI_NOT_FOUND; } @@ -1303,6 +1304,7 @@ GetDecimalUintnFromDataFile ( if (EFI_ERROR(Status)) { return EFI_NOT_FOUND; } + ASSERT (Value != NULL); if (!IsValidDecimalString(Value, AsciiStrLen(Value))) { return EFI_NOT_FOUND; } @@ -1346,6 +1348,7 @@ GetHexUintnFromDataFile ( if (EFI_ERROR(Status)) { return EFI_NOT_FOUND; } + ASSERT (Value != NULL); if (!IsValidHexString(Value, AsciiStrLen(Value))) { return EFI_NOT_FOUND; } @@ -1389,6 +1392,7 @@ GetHexUint64FromDataFile ( if (EFI_ERROR(Status)) { return EFI_NOT_FOUND; } + ASSERT (Value != NULL); if (!IsValidHexString(Value, AsciiStrLen(Value))) { return EFI_NOT_FOUND; } -- 2.39.2