From dd4e2bcfaa068fd958169944e99149fa06b58354 Mon Sep 17 00:00:00 2001 From: "Yao, Jiewen" Date: Tue, 7 Jul 2015 05:47:08 +0000 Subject: [PATCH 1/1] FspInitPei function calling parameters not matching with the function definition. IntelFspWrapperPkg, In the file FspInitPeiV1.c and FspInitPeiV2.c, there are function calling: GetStackInfo (BootMode, FALSE, &StackBase, &StackSize); But the function GetStackInfo() defined as EFI_STATUS EFIAPI GetStackInfo ( IN UINT32 BootMode, IN BOOLEAN FspInitDone, OUT UINT64 *StackSize, OUT EFI_PHYSICAL_ADDRESS *StackBase ) It should be GetStackInfo (BootMode, FALSE, &StackSize, &StackBase); Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Reviewed-by: "Ma, Maurice" Reviewed-by: "Rangarajan, Ravi P" git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17850 6f19259b-4bc3-4df7-8a09-765794883524 --- IntelFspWrapperPkg/FspInitPei/FspInitPeiV1.c | 4 ++-- IntelFspWrapperPkg/FspInitPei/FspInitPeiV2.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/IntelFspWrapperPkg/FspInitPei/FspInitPeiV1.c b/IntelFspWrapperPkg/FspInitPei/FspInitPeiV1.c index da7f8238d7..b145b50c09 100644 --- a/IntelFspWrapperPkg/FspInitPei/FspInitPeiV1.c +++ b/IntelFspWrapperPkg/FspInitPei/FspInitPeiV1.c @@ -47,7 +47,7 @@ ContinuationFunc ( // BootMode = GetBootMode (); - GetStackInfo (BootMode, TRUE, &StackBase, &StackSize); + GetStackInfo (BootMode, TRUE, &StackSize, &StackBase); DEBUG ((DEBUG_INFO, "StackBase - 0x%x\n", StackBase)); DEBUG ((DEBUG_INFO, "StackSize - 0x%x\n", StackSize)); CallPeiCoreEntryPoint ( @@ -81,7 +81,7 @@ PeiFspInit ( PeiServicesGetBootMode (&BootMode); DEBUG ((DEBUG_INFO, "BootMode - 0x%x\n", BootMode)); - GetStackInfo (BootMode, FALSE, &StackBase, &StackSize); + GetStackInfo (BootMode, FALSE, &StackSize, &StackBase); DEBUG ((DEBUG_INFO, "StackBase - 0x%x\n", StackBase)); DEBUG ((DEBUG_INFO, "StackSize - 0x%x\n", StackSize)); diff --git a/IntelFspWrapperPkg/FspInitPei/FspInitPeiV2.c b/IntelFspWrapperPkg/FspInitPei/FspInitPeiV2.c index 35a994e960..50b150aedd 100644 --- a/IntelFspWrapperPkg/FspInitPei/FspInitPeiV2.c +++ b/IntelFspWrapperPkg/FspInitPei/FspInitPeiV2.c @@ -148,7 +148,7 @@ PeiFspMemoryInit ( PeiServicesGetBootMode (&BootMode); DEBUG ((DEBUG_INFO, "BootMode - 0x%x\n", BootMode)); - GetStackInfo (BootMode, FALSE, &StackBase, &StackSize); + GetStackInfo (BootMode, FALSE, &StackSize, &StackBase); DEBUG ((DEBUG_INFO, "StackBase - 0x%x\n", StackBase)); DEBUG ((DEBUG_INFO, "StackSize - 0x%x\n", StackSize)); -- 2.39.2