From df43ea6c08100487776bb0962c657d214e345ae7 Mon Sep 17 00:00:00 2001 From: "Feng, Bob C" Date: Wed, 28 Aug 2019 15:33:45 +0800 Subject: [PATCH] BaseTools: fix an incremental build issue. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2137 This patch is going to fix a regression issue of incremental build which was introduced by the commit 94459080c. The changing on INF file will not trigger module rebuild. Signed-off-by: Bob Feng Cc: Liming Gao Cc: Steven Shi Tested-by: Michael D Kinney Acked-by: Michael D Kinney Reviewed-by: Liming Gao --- BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py index 2cd0d3859e..f610365f6d 100755 --- a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py +++ b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py @@ -1766,12 +1766,8 @@ class ModuleAutoGen(AutoGen): if os.path.exists (self.TimeStampPath): os.remove (self.TimeStampPath) - with tempfile.NamedTemporaryFile('w+', dir=os.path.dirname(self.TimeStampPath), delete=False) as tf: - for f in FileSet: - tf.write(f) - tf.write("\n") - tempname = tf.name - SaveFileOnChange(self.TimeStampPath, tempname, False) + + SaveFileOnChange(self.TimeStampPath, "\n".join(FileSet), False) # Ignore generating makefile when it is a binary module if self.IsBinaryModule: -- 2.39.2