From ef62da4ff742a0b9f4b718ccc2a03f5497115c9f Mon Sep 17 00:00:00 2001 From: Antoine Coeur Date: Fri, 7 Feb 2020 02:08:30 +0100 Subject: [PATCH] UefiCpuPkg/PiSmm: Fix various typos Fix various typos in comments and documentation. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Laszlo Ersek Reviewed-by: Eric Dong Signed-off-by: Philippe Mathieu-Daude Message-Id: <20200207010831.9046-78-philmd@redhat.com> --- .../PiSmmCommunication/PiSmmCommunicationPei.c | 2 +- .../PiSmmCommunication/PiSmmCommunicationSmm.c | 2 +- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 4 ++-- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 12 ++++++------ UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 4 ++-- UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 6 +++--- UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c | 2 +- UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 2 +- UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm | 2 +- 9 files changed, 18 insertions(+), 18 deletions(-) diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c index 5d09130e55..68e5003ad4 100644 --- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c +++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c @@ -366,7 +366,7 @@ Communicate ( @param FileHandle Handle of the file being invoked. @param PeiServices Pointer to PEI Services table. - @retval EFI_SUCEESS + @retval EFI_SUCCESS @return Others Some error occurs. **/ EFI_STATUS diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c index 6be12d6c14..30f7d57bdd 100644 --- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c +++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c @@ -155,7 +155,7 @@ AllocateAcpiNvsMemoryBelow4G ( @param[in] ImageHandle Image handle of this driver. @param[in] SystemTable A Pointer to the EFI System Table. - @retval EFI_SUCEESS + @retval EFI_SUCCESS @return Others Some error occurs. **/ EFI_STATUS diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c index 723fd5042f..db68e1316e 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c @@ -215,7 +215,7 @@ DumpModuleInfoByIp ( @retval EFI_SUCCESS The register was read from Save State @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor - @retval EFI_INVALID_PARAMTER This or Buffer is NULL. + @retval EFI_INVALID_PARAMETER This or Buffer is NULL. **/ EFI_STATUS @@ -287,7 +287,7 @@ SmmReadSaveState ( @retval EFI_SUCCESS The register was written from Save State @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor - @retval EFI_INVALID_PARAMTER ProcessorIndex or Width is not correct + @retval EFI_INVALID_PARAMETER ProcessorIndex or Width is not correct **/ EFI_STATUS diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h index 33b3dd140e..fe7e8b0323 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h @@ -284,7 +284,7 @@ extern UINT8 mSmmSaveStateRegisterLma; @retval EFI_SUCCESS The register was read from Save State @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor - @retval EFI_INVALID_PARAMTER This or Buffer is NULL. + @retval EFI_INVALID_PARAMETER This or Buffer is NULL. **/ EFI_STATUS @@ -308,7 +308,7 @@ SmmReadSaveState ( @retval EFI_SUCCESS The register was written from Save State @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor - @retval EFI_INVALID_PARAMTER ProcessorIndex or Width is not correct + @retval EFI_INVALID_PARAMETER ProcessorIndex or Width is not correct **/ EFI_STATUS @@ -336,7 +336,7 @@ This function supports reading a CPU Save State register in SMBase relocation ha @retval EFI_SUCCESS The register was read from Save State. @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor. -@retval EFI_INVALID_PARAMTER This or Buffer is NULL. +@retval EFI_INVALID_PARAMETER This or Buffer is NULL. **/ EFI_STATUS @@ -363,7 +363,7 @@ This function supports writing a CPU Save State register in SMBase relocation ha @retval EFI_SUCCESS The register was written to Save State. @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor. -@retval EFI_INVALID_PARAMTER ProcessorIndex or Width is not correct. +@retval EFI_INVALID_PARAMETER ProcessorIndex or Width is not correct. **/ EFI_STATUS @@ -1263,7 +1263,7 @@ EdkiiSmmGetMemoryAttributes ( /** This function fixes up the address of the global variable or function - referred in SmmInit assembly files to be the absoute address. + referred in SmmInit assembly files to be the absolute address. **/ VOID EFIAPI @@ -1272,7 +1272,7 @@ PiSmmCpuSmmInitFixupAddress ( /** This function fixes up the address of the global variable or function - referred in SmiEntry assembly files to be the absoute address. + referred in SmiEntry assembly files to be the absolute address. **/ VOID EFIAPI diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c index 55090e9c3e..9c5a92af64 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c @@ -465,7 +465,7 @@ ConvertMemoryPageAttributes ( } // - // Below logic is to check 2M/4K page to make sure we donot waist memory. + // Below logic is to check 2M/4K page to make sure we do not waste memory. // while (Length != 0) { PageEntry = GetPageTableEntry (BaseAddress, &PageAttribute); @@ -1065,7 +1065,7 @@ IsUefiPageNotPresent ( } /** - Merge continous memory map entries whose type is + Merge continuous memory map entries whose type is EfiLoaderCode/Data, EfiBootServicesCode/Data, EfiConventionalMemory, EfiUnusableMemory, EfiACPIReclaimMemory, because the memory described by these entries will be set as NOT present in SMM page table. diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c b/UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c index b1a492725a..661cc51f36 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c @@ -260,7 +260,7 @@ GetRegisterIndex ( @retval EFI_SUCCESS The register was read from Save State. @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor. - @retval EFI_INVALID_PARAMTER This or Buffer is NULL. + @retval EFI_INVALID_PARAMETER This or Buffer is NULL. **/ EFI_STATUS @@ -343,7 +343,7 @@ ReadSaveStateRegisterByIndex ( @retval EFI_SUCCESS The register was read from Save State. @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor. - @retval EFI_INVALID_PARAMTER This or Buffer is NULL. + @retval EFI_INVALID_PARAMETER This or Buffer is NULL. **/ EFI_STATUS @@ -455,7 +455,7 @@ ReadSaveStateRegister ( @retval EFI_SUCCESS The register was written to Save State. @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor. - @retval EFI_INVALID_PARAMTER ProcessorIndex or Width is not correct. + @retval EFI_INVALID_PARAMETER ProcessorIndex or Width is not correct. **/ EFI_STATUS diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c index ce1bf9fb54..8c9de1fdae 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c @@ -58,7 +58,7 @@ SemaphoreHook ( ); // - // Use temp value to fix ICC complier warning + // Use temp value to fix ICC compiler warning // TempValue = (UINTN)&mSmmRelocationOriginalAddress; PatchInstructionX86 ( diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm index db06d22d51..8bfba55b5d 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm @@ -16,7 +16,7 @@ %include "Nasm.inc" ; -; Variables referrenced by C code +; Variables referenced by C code ; %define MSR_IA32_S_CET 0x6A2 diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm index 8d81582bb1..9cf3a6dcf9 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm @@ -72,7 +72,7 @@ BITS 64 ASM_PFX(gPatchSmmInitStack): and sp, 0xfff0 ; make sure RSP is 16-byte aligned ; - ; Accoring to X64 calling convention, XMM0~5 are volatile, we need to save + ; According to X64 calling convention, XMM0~5 are volatile, we need to save ; them before calling C-function. ; sub rsp, 0x60 -- 2.39.2