From f21547ff64a58909c85ce215531345f6f8364884 Mon Sep 17 00:00:00 2001 From: Yonghong Zhu Date: Thu, 18 Jan 2018 11:13:06 +0800 Subject: [PATCH] BaseTools: enhance error handling for option --binary-source Enhance error handling for option --binary-source to report invalid option value. --binary-destination use same rule. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu Reviewed-by: Liming Gao --- BaseTools/Source/Python/build/build.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Python/build/build.py index de19756d99..e4adee2beb 100644 --- a/BaseTools/Source/Python/build/build.py +++ b/BaseTools/Source/Python/build/build.py @@ -794,12 +794,18 @@ class Build(): if not os.path.isabs(BinCacheSource): BinCacheSource = mws.join(self.WorkspaceDir, BinCacheSource) GlobalData.gBinCacheSource = BinCacheSource + else: + if GlobalData.gBinCacheSource != None: + EdkLogger.error("build", OPTION_VALUE_INVALID, ExtraData="Invalid value of option --binary-source.") if GlobalData.gBinCacheDest: BinCacheDest = os.path.normpath(GlobalData.gBinCacheDest) if not os.path.isabs(BinCacheDest): BinCacheDest = mws.join(self.WorkspaceDir, BinCacheDest) GlobalData.gBinCacheDest = BinCacheDest + else: + if GlobalData.gBinCacheDest != None: + EdkLogger.error("build", OPTION_VALUE_INVALID, ExtraData="Invalid value of option --binary-destination.") if self.ConfDirectory: # Get alternate Conf location, if it is absolute, then just use the absolute directory name -- 2.39.2