From ffbc792ce5edf8ec6250c9808dc4bcad8cfd08b8 Mon Sep 17 00:00:00 2001 From: Elvin Li Date: Fri, 1 Aug 2014 05:08:40 +0000 Subject: [PATCH] MdeModulePkg: Fix wrong check for SetAttribute in Consplitter Original code check if Attribute > 0x7FFFFFFF, this is wrong and fail to check valid case per UEFI spec. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Elvin Li Reviewed-by: Jaben Carsey git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15734 6f19259b-4bc3-4df7-8a09-765794883524 --- MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c index a0a2dd3358..bea206d35b 100644 --- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c +++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c @@ -16,7 +16,7 @@ never removed. Such design ensures sytem function well during none console device situation. -Copyright (c) 2006 - 2012, Intel Corporation. All rights reserved.
+Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -4557,7 +4557,7 @@ ConSplitterTextOutSetAttribute ( // // Check whether param Attribute is valid. // - if ( (Attribute > (UINTN)(((UINT32)-1)>>1)) ) { + if ((Attribute | 0x7F) != 0x7F) { return EFI_UNSUPPORTED; } -- 2.39.2