Martin Winter [Fri, 13 Oct 2017 23:17:26 +0000 (16:17 -0700)]
Release: FRR 3.0
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Thu, 12 Oct 2017 00:56:17 +0000 (17:56 -0700)]
Revert "ospfd: Free memory associated with ospf instance startup"
This reverts commit
79942104bff838362cd6609485a26617492aa6f5.
The original commit causes a heap-use-after-free. See issue
https://github.com/FRRouting/frr/issues/1326
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Tue, 10 Oct 2017 22:13:10 +0000 (15:13 -0700)]
release: FRR 3.0-rc3
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Donald Sharp [Tue, 10 Oct 2017 16:33:36 +0000 (12:33 -0400)]
Merge pull request #1320 from opensourcerouting/Debian-Pkg-3.0
Debian pkg 3.0
Martin Winter [Tue, 10 Oct 2017 06:14:27 +0000 (23:14 -0700)]
debianpkg: Fix non-empty-dependency_libs-in-la-file for frr modules
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Tue, 10 Oct 2017 01:17:09 +0000 (18:17 -0700)]
debian-pkg: Remove hardening-wrapper and replace with dpkg-buildflags
* hardening-wrapper is obsolete
* Fixes Issue #967
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Mon, 9 Oct 2017 09:33:11 +0000 (02:33 -0700)]
debianpkg: Always build FPM module
- FPM is a module since 3.0. Always build it and allow user choice to enable or disable it
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Fri, 29 Sep 2017 02:59:35 +0000 (19:59 -0700)]
debianpkg: Remove -werror from Ubuntu 14.04 and 12.04 build to skip warnings from flex generated code
- Flex is too old on these releases and misses some prototypes in the generated code. Removing the
werror allows to build the package anyway
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Fri, 29 Sep 2017 01:09:44 +0000 (18:09 -0700)]
debianpkg: Add missing XSBC-Original-Maintainer field (fixes merge error)
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Fri, 29 Sep 2017 00:35:24 +0000 (17:35 -0700)]
debianpkg: Fix leftover marking from merge
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Fri, 29 Sep 2017 00:08:31 +0000 (17:08 -0700)]
debianpkg: Fix some old references to freerangerouting instead of frrouting
smccroskey [Tue, 8 Aug 2017 21:51:38 +0000 (14:51 -0700)]
frr.lintian-overrides: update for current list of built libs
Because the lintian warning no longer matched exactly due to removal
of unused protobuf libraries from the build, the warning wasn't
masked. Update it to match the current warning string.
Signed-off-by: Silas McCroskey <smccroskey@cumulusnetworks.com>
smccroskey [Tue, 8 Aug 2017 19:22:29 +0000 (12:22 -0700)]
ubuntu trusty/precise: remove leftover debconf call
Forgot to unstash this when attempting to rebase it into
1e6df754913b4218ec809742fe0fff4eb8461035.
Signed-off-by: Silas McCroskey <smccroskey@cumulusnetworks.com>
smccroskey [Tue, 8 Aug 2017 18:36:10 +0000 (11:36 -0700)]
debianpkg/Makefile.am: remove frr.config
File was removed by
1e6df754913b4218ec809742fe0fff4eb8461035
but missed removing it from the Makefile.am.
Signed-off-by: Silas McCroskey <smccroskey@cumulusnetworks.com>
smccroskey [Tue, 8 Aug 2017 18:24:05 +0000 (11:24 -0700)]
debianpkg/Makefile.am: remove po/ directory
Directory was removed by
1e6df754913b4218ec809742fe0fff4eb8461035 but
missed removing it from the Makefile.am.
Signed-off-by: Silas McCroskey <smccroskey@cumulusnetworks.com>
smccroskey [Sat, 29 Jul 2017 00:29:36 +0000 (17:29 -0700)]
frr.service: remove explicit dependency on socket-based syslog.target
Testing done: built and installed for all ubuntu targets
Socket-based services such as syslog need not be specified as
dependencies in service files, and doing so may slow down boot by
reducing parallelism. All known supported systemd-based platforms
have syslog as a socket-based service.
Clears the following lintian warnings:
W: frr: systemd-service-file-refers-to-obsolete-target lib/systemd/system/frr.service syslog.target
Signed-off-by: Silas McCroskey <smccroskey@cumulusnetworks.com>
smccroskey [Sat, 29 Jul 2017 00:25:30 +0000 (17:25 -0700)]
pb libs: don't build if protobuf support is disabled
Testing done: built and installed for all ubuntu targets
These library targets should not be built if protobuf support is
disabled, as that is their only functionality.
Clears the following lintian warnings:
W: frr: non-dev-pkg-with-shlib-symlink usr/lib/libfrr_pb.so.0.0.0 usr/lib/libfrr_pb.so
W: frr: non-dev-pkg-with-shlib-symlink usr/lib/libfrrfpm_pb.so.0.0.0 usr/lib/libfrrfpm_pb.so
W: frr-dbg: debug-file-with-no-debug-symbols usr/lib/debug/usr/lib/libfrr_pb.so.0.0.0
W: frr-dbg: debug-file-with-no-debug-symbols usr/lib/debug/usr/lib/libfrrfpm_pb.so.0.0.0
Signed-off-by: Silas McCroskey <smccroskey@cumulusnetworks.com>
smccroskey [Sat, 29 Jul 2017 00:22:20 +0000 (17:22 -0700)]
ubuntu12.04: shorten frr-dbg description
Testing done: built and installed on all ubuntu
Fix was applied elsewhere but didn't make it into this file.
Clears the following lintian warning:
W: frr-dbg: description too long
Signed-off-by: Silas McCroskey <smccroskey@cumulusnetworks.com>
smccroskey [Thu, 27 Jul 2017 01:45:52 +0000 (18:45 -0700)]
deb-based-distros: clean up leftover debconf references
Testing done: built and installed on all ubuntu
Debconf was in use by this packaging a long time ago, and references to it
were never fully cleaned up when the one question it asked was deleted.
Clears the following lintian warning:
W: frr: no-debconf-templates
Signed-off-by: Silas McCroskey <smccroskey@cumulusnetworks.com>
smccroskey [Thu, 20 Jul 2017 18:58:43 +0000 (11:58 -0700)]
backports: don't install frr-reload.py in frr package
Testing done: built in sbuild with lintian enabled
verified frr-reload.py still in frr-pythontools
Clean up issues missed when moving the script into a separate package.
Clears the following lintian warning:
E: frr: python-script-but-no-python-dep usr/lib/frr/frr-reload.py
Signed-off-by: Silas McCroskey <smccroskey@cumulusnetworks.com>
smccroskey [Mon, 29 May 2017 22:34:02 +0000 (15:34 -0700)]
debian: install PNG files in /usr/share/info
Testing done: built in sbuild with lintian enabled
Clears lintian warnings of the following form:
W: frr-doc: info-document-missing-image-file
According to the documentation for the lintian warning, certain
applications (e.g. emacs) can render images from info files inline,
and expect the images to either have their full path defined or be
installed in the same directory as the info files themselves.
Automake doesn't seem to have a primary for handling this sort of
installation (info_DATA is invalid and causes an error), so opted to
handle it in the debian install file itself.
Installing the images elsewhere (another path installed by frr-doc)
and giving a full path to their location in info files might be a
better approach.
Signed-off-by: Silas McCroskey <smccroskey@cumulusnetworks.com>
Martin Winter [Sat, 8 Jul 2017 01:37:58 +0000 (18:37 -0700)]
debianpkg: Overriding lintian package-name-doesnt-match-sonames warning
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Silas McCroskey [Fri, 7 Jul 2017 22:16:20 +0000 (15:16 -0700)]
debianpkg: Fix 'make backports' warning about autopkgtest
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Fri, 16 Jun 2017 22:49:27 +0000 (15:49 -0700)]
debianpkg: Move frr-reload.py to frr-pythontools subpackage
- avoids python dependency on main frr package
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Fri, 16 Jun 2017 00:30:08 +0000 (17:30 -0700)]
debianpkg: Register/remove init script on init.d based systems
- Ubuntu 12.04 and Ubuntu 14.04 need init script registered during
install and removed at uninstall
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Thu, 15 Jun 2017 21:23:09 +0000 (14:23 -0700)]
debianpkg: Fix description (make shorter - max 80 chars)
- Fixes lintian error 'description-too-long'
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Wed, 14 Jun 2017 01:06:14 +0000 (18:06 -0700)]
debianpkg: Support --with-pkg-extra-version and other modifier to build custom package version
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Tue, 13 Jun 2017 02:32:02 +0000 (19:32 -0700)]
debianpkg: Cleanup configure options
- Make them configurable (with WANT_xxx env variables)
- Adjust defaults to generic package
- remove obsolete configure options
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Mon, 12 Jun 2017 23:14:03 +0000 (16:14 -0700)]
debianpkg: Do not start package after installation
- Remove auto-start from Ubuntu 12.04 Backport
- Update Doc to explain on how to enable startup
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Sat, 10 Jun 2017 09:20:29 +0000 (02:20 -0700)]
tools: Rename to FRRouting in frr.service file
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Sat, 10 Jun 2017 03:41:09 +0000 (20:41 -0700)]
debianpkg/Ubuntu12.04-backport: Remove accidental reference to frr_sudoers
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Fri, 9 Jun 2017 22:57:32 +0000 (15:57 -0700)]
debianpkg: Update control to fix maintainer email
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Fri, 9 Jun 2017 22:30:21 +0000 (15:30 -0700)]
debianpkg: Fix Date format in changelog and version numbering to make sure custom build is newer
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Fri, 9 Jun 2017 08:58:31 +0000 (01:58 -0700)]
debianpkg: Add backport for Debian 8
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Fri, 9 Jun 2017 06:30:09 +0000 (23:30 -0700)]
debianpkg: debian rules file needs to be executable
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Fri, 9 Jun 2017 06:12:02 +0000 (23:12 -0700)]
debianpkg: Update Build-Depends to use libjson-c-dev / libjson-c2 instead of libjson0 on newer debian systems
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Fri, 9 Jun 2017 03:34:22 +0000 (20:34 -0700)]
debianpkg: Add initial README to document the steps required to build the debian packages with backports
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Fri, 9 Jun 2017 02:14:41 +0000 (19:14 -0700)]
debian->debianpkg: Move debian files from debian dir to debianpkg dir.
Debian build systems use debian subdir for building and having a debian
dir in the source package causes issues.
Moving it to debianpkg avoids the issue and allows us to ship debian
package files in the source distribution
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
smccroskey [Fri, 28 Apr 2017 07:00:53 +0000 (00:00 -0700)]
backports: minimize diffs with base debian files
minimize diffs between the base debian files and each backport to the
changes that actually matter, so that they aren't lost in the noise of
capitalization and ordering differences.
Signed-off-by: Silas McCroskey <smccroskey@cumulusnetworks.com>
smccroskey [Fri, 28 Apr 2017 06:58:13 +0000 (23:58 -0700)]
debian: clean up, update base debian/control
this removes some cruft -- old/outdated/incorrect information,
trailing whitespace, etc., and updates the descriptions. Some small
changes were made where appropriate to minimize the diff between the
base control file and those of the various backports.
Signed-off-by: Silas McCroskey <smccroskey@cumulusnetworks.com>
smccroskey [Thu, 27 Apr 2017 23:42:43 +0000 (16:42 -0700)]
debian: delete unused files out of debian/
These are unused and not referenced anywhere.
debian/rules.orig: included by mistake
debian/watch: no longer applicable; url is not valid
debian/patches: stale, unused, misleading
Signed-off-by: Silas McCroskey <smccroskey@cumulusnetworks.com>
smccroskey [Thu, 27 Apr 2017 21:31:29 +0000 (14:31 -0700)]
precise/trusty: don't attempt to install pimd or ldpd manuals
Neither of these daemons are installed on 14.04, leading to build
failures now that the man pages are excluded from the Makefiles when
the daemons aren't enabled for install.
Signed-off-by: Silas McCroskey <smccroskey@cumulusnetworks.com>
smccroskey [Thu, 27 Apr 2017 21:27:09 +0000 (14:27 -0700)]
backports: error out on upstream/downstream version mismatch
The quilt source format expects the upstream tarball's version to
correspond roughly to the debian version of the package, and errors
will be thrown (at unpack time, in our case) if it doesn't. Do a
sanity check when we're building the source package to make sure they
match up.
Signed-off-by: Silas McCroskey <smccroskey@cumulusnetworks.com>
Martin Winter [Thu, 16 Feb 2017 18:49:00 +0000 (01:49 +0700)]
debian: Fix some incorrect references to Quagga instead of FRR
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Silas McCroskey [Tue, 14 Feb 2017 17:48:57 +0000 (00:48 +0700)]
backports: symlink identical files
Testing-done: built all backports in schroots and VMs
made files identical between different backports symlinks
to the ones for the more recent distribution, and updated
relevant tar invocations to follow symlinks.
Signed-off by: Silas McCroskey <smccroskey@cumulusnetworks.com>
Silas McCroskey [Tue, 14 Feb 2017 17:34:42 +0000 (00:34 +0700)]
debian: add pkg-config to build-depends
Testing-done: `--add-depends pkg-config' sbuild
The dependency on pkg-config was introduced recently, and
missed because it's in our schroots by default. Need to add
it for other build environments (e.g. ubuntu schroots).
Signed-off by: Silas McCroskey <smccroskey@cumulusnetworks.com>
Silas McCroskey [Tue, 14 Feb 2017 15:48:19 +0000 (22:48 +0700)]
debian: move ubuntu 16.04 files into new backports system
Added 'debian/patches' to the exclude file, since the existing patches
interfere with the build and are unused by our build. No other
changes were necessary. Used '-0~ubuntu16.04+1' as the version
extention, to denote: no patches (-0), debian packaging files changed
for backport (+1).
Signed-off-by: Silas McCroskey <smccroskey@cumulusnetworks.com>
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Silas McCroskey [Tue, 14 Feb 2017 15:44:17 +0000 (22:44 +0700)]
debian: move ubuntu 14.04 files into new backports system
`git diff'ed the main (cmaster) branch against the 14.04 branch
to determine changed debian files, then pulled them into
debian/backports via `git cat-file'. Added 'debian/patches' to
the exclude file, since the existing patches interfere with the
build and are unused by our build. Used '-0~ubuntu14.04+1' as
the version extention, to denote: no patches (-0), debian
packaging files changed for backport (+1).
Original commit by Silas with updates on fork name by Martin
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Silas McCroskey [Tue, 14 Feb 2017 15:34:56 +0000 (22:34 +0700)]
debian: move ubuntu 12.04 files into new backports system
`git diff'ed the main (cmaster) branch against the 12.04 branch
to determine changed debian files, then pulled them into
debian/backports via `git cat-file'. Added 'debian/patches' to
the exclude file, since the existing patches interfere with the
build and are unused by our build. Used '-0~ubuntu12.04+1' as
the version extention, to denote: no patches (-0), debian
packaging files changed for backport (+1).
Original commit by Silas with updates on fork name by Martin
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Silas McCroskey [Tue, 14 Feb 2017 12:04:10 +0000 (19:04 +0700)]
debian/backports: include in distfile, don't put files in ..
Testing-done: ran 'make dist', unpacked elsewhere, built from result
Adjusted target to build the .orig.tar.gz accordingly, since it must
exclude the debian/ subdirectory. Allows for building any backport from
only a tarball.
Signed-off-by: Silas McCroskey <smccroskey@cumulusnetworks.com>
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Silas McCroskey [Tue, 14 Feb 2017 11:52:40 +0000 (18:52 +0700)]
debian: fix dpkg tool invocations to work on Ubuntu 12.04
dpkg-parsechangelog and dpkg-source were both using flags
not yet available in the versions available on 12.04.
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Silas McCroskey [Tue, 14 Feb 2017 11:45:50 +0000 (18:45 +0700)]
debian: structure for building backports from a single branch
Source a makefile (when it exists) in debian/rules to assemble
a source package via:
* a debian.tar.gz tarball built from combining the contents of debian/
and debian/backports/$backport/debian/ using other details under
debian/backports/$backport
* an orig.tar.gz file (not generated by this makefile). This can (and
should) be the same for all backports.
Details in debian/backports/README
Signed-off-by: Silas McCroskey <smccroskey@cumulusnetworks.com>
Donald Sharp [Tue, 10 Oct 2017 12:23:22 +0000 (08:23 -0400)]
Merge pull request #1318 from opensourcerouting/bgp_mplsvpn_werror_fix
bgpd: fix werror warning for potentially uninitialized variable
Martin Winter [Tue, 10 Oct 2017 02:27:44 +0000 (19:27 -0700)]
bgpd: fix werror warning for potentially uninitialized variable
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Lou Berger [Mon, 9 Oct 2017 13:56:51 +0000 (09:56 -0400)]
Merge pull request #1284 from donaldsharp/more_mem_leaks
More mem leaks
Renato Westphal [Tue, 3 Oct 2017 19:11:07 +0000 (16:11 -0300)]
ldpd: detach stdin/stdout/stderr from the child processes
Doing a "ssh user@node 'ldpd -d'" was making the SSH session hang. In
the original OpenBSD's ldpd(8) daemon, the daemon function takes care
of connecting stdin/stdout/stderr to /dev/null. In the FRR port, this
only happens in the frr_run() function, after all children have been
forked. Ideally we could try to rearrange libfrr.c and ldpd.c in a way
that start_child() is called only after the parent connects the standard
I/O streams to /dev/null. But since this issue needs an immediate
fix, let's do this workaround for now. Note: even when running on the
foreground, all log messages from the child processes are sent to the
parent process, which then prints the messages to stdout/stderr and/or
to a log file.
Reported-by: Martin Winter <mwinter@opensourcerouting.org>
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
Donald Sharp [Wed, 4 Oct 2017 12:49:14 +0000 (08:49 -0400)]
isisd: Allow adjacency cleanup to free malloc'ed memory
The `struct isis_adjacency` needs to free up memory
associated with the area_addrs ipv4_addrs and ipv6_addrs
lists.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Wed, 4 Oct 2017 12:35:29 +0000 (08:35 -0400)]
ospf6d: When removing a vertex free memory associated with it
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Wed, 4 Oct 2017 12:04:00 +0000 (08:04 -0400)]
ospfd: Free memory associated with ospf instance startup
We have memory that is initialized upon ospf instance
and area startup. Free it up on shutdown.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Wed, 4 Oct 2017 11:55:58 +0000 (07:55 -0400)]
ripngd: Fix possible memory leak of route_node
There exists a path where we do not save the route_node
after creation. Allow cleanup.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Andreas Jaggi [Fri, 8 Sep 2017 11:46:20 +0000 (07:46 -0400)]
bgpd: Fix AS_PATH size calculation for long paths
If you have an AS_PATH with more entries than
what can be written into a single AS_SEGMENT_MAX
it needs to be broken up. The code that noticed
that the AS_PATH needs to be broken up was not
correctly calculating the size of the resulting
message. This patch addresses this issue.
This patch was built from an email that Andreas
sent to the dev alias for FRRouting.
Fixes: #1114
Signed-off-by: Andreas Jaggi <aj@open.ch>
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Renato Westphal [Sun, 24 Sep 2017 13:54:13 +0000 (10:54 -0300)]
Merge pull request #1217 from qlyoung/fix-heap-uaf-ospf6
ospf6d: fix heap use after free
Quentin Young [Thu, 21 Sep 2017 20:03:17 +0000 (16:03 -0400)]
ospf6d: fix heap use after free
During the loop we save a pointer to the next route in the table in case
brouter is deleted during the course of the loop iteration. However when
we call ospf6_route_remove this can trigger ospf6_route_remove on other
routes in the table, one of which could be pointed at by said pointer.
Since ospf6_route_next locks the route that it returns, it won't
actually be deleted, instead the refcount will go to 1. In the next loop
iteration, nbrouter becomes brouter, and calling ospf6_route_next on
this one will finally decrement the refcount to 0, resulting in a free,
which causes subsequent reads on brouter to be UAF. Since the route will
have OSPF6_ROUTE_WAS_REMOVED set, provided the memory was not
overwritten before we got there, we'll continue on to the next one so it
is unlikely this will cause a crash in production.
Solution implemented is to check if we've deleted the route and continue
if so.
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
Eric Pulvino [Mon, 18 Sep 2017 15:53:29 +0000 (11:53 -0400)]
Adding Useful Sysctl Settings recommendations.
Donald Sharp [Thu, 21 Sep 2017 12:50:26 +0000 (08:50 -0400)]
Merge pull request #1152 from nkukard/docs-ip-bgp
doc: Updates for 3.0
Donald Sharp [Thu, 21 Sep 2017 12:50:02 +0000 (08:50 -0400)]
Merge branch 'stable/3.0' into docs-ip-bgp
Renato Westphal [Thu, 21 Sep 2017 12:42:45 +0000 (09:42 -0300)]
Merge pull request #1211 from donaldsharp/mem_leaks
Mem leaks
Donald Sharp [Wed, 20 Sep 2017 16:56:38 +0000 (12:56 -0400)]
bgpd: Fix json memory leak
When issuing 'show bgp ...' commands that dump
the entire table, we were dropping the initial
json_paths = json_object_new_object() memory
allocation. Fix this.
Additionally reformat the output to fit
better in 80 columns.
There may be additional memory leaks here
hidden away in how we decide to continue
or not.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Wed, 20 Sep 2017 16:52:38 +0000 (12:52 -0400)]
zebra: Free leaked zclient data structures on shutdown
On shutdown we were deleting the linked list that
kept the zclient connections, but we were not
freeing the data pointed at by the link list.
This modification allows the normal cleanup of the
linked list to cleanup the zclient data structure.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Wed, 20 Sep 2017 16:51:27 +0000 (12:51 -0400)]
ripd: Free leaked memory on shutdown
Usage of the address sanitizer and topotests showed
that rip was leaking obuf on shutdown
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Mon, 22 May 2017 19:43:20 +0000 (15:43 -0400)]
vtysh: Cleanup some stuff(tm)
1) vtysh_config_dump was not properly indented. Fix
2) Add VRF_NODE to be line_uniq when parsing return from sub-daemons
3) Fix 'no log monitor' to be line_uniq as well
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Wed, 20 Sep 2017 11:55:55 +0000 (07:55 -0400)]
Merge pull request #1176 from opensourcerouting/isis-stable-circuit-ids
isisd: generate unique circuit ids
Quentin Young [Wed, 21 Jun 2017 18:42:17 +0000 (18:42 +0000)]
vtysh: fix various show commands
need 'do' to force ENABLE_NODE
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
Quentin Young [Wed, 14 Jun 2017 19:47:14 +0000 (19:47 +0000)]
lib: allow 'do' commands in ENABLE_NODE
'do' is syntax sugar that allows the user to execute a command under
ENABLE_NODE when in another CLI node. If the user is already in
ENABLE_NODE, use of 'do' was previously disallowed. This patch allows it
because it makes it easier for us to hack around certain instances of
the node synchronization problem with vtysh.
Also included is a fix for one of these problems.
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
Christian Franke [Thu, 14 Sep 2017 13:26:33 +0000 (15:26 +0200)]
isisd: generate unique circuit ids
Circuit IDs need to be unique, otherwise mayhem will ensue.
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
Renato Westphal [Tue, 12 Sep 2017 12:46:31 +0000 (09:46 -0300)]
ldpd: fix broken label allocation
Once ldpd allocated label 48 for a given FEC, all subsequent requests
for a new label would return the same value (48). The problem is that
we were left shifting an uint32_t value up to 64 times, losing important
information.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
Russ White [Wed, 13 Sep 2017 20:24:30 +0000 (16:24 -0400)]
Merge pull request #1159 from opensourcerouting/doc-tcp-zebra
doc: remove --enable-tcp-zebra from the build instructions (3.0)
Russ White [Wed, 13 Sep 2017 20:18:57 +0000 (16:18 -0400)]
Merge pull request #1168 from donaldsharp/show_ver
lib: Add json support for 'show version' command
Donald Sharp [Tue, 12 Sep 2017 20:27:39 +0000 (16:27 -0400)]
lib: Add json support for 'show version' command
Fixes: #1167
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Tue, 12 Sep 2017 17:23:51 +0000 (13:23 -0400)]
release: FRR 3.0-rc2
Renato Westphal [Tue, 12 Sep 2017 12:58:00 +0000 (09:58 -0300)]
doc: remove --enable-tcp-zebra from the build instructions
This parameter was removed by commit
01c9f29.
Fixes #1146.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
David Lamparter [Mon, 11 Sep 2017 09:00:28 +0000 (11:00 +0200)]
Merge pull request #1141 from nkukard/lc-docs-3.0
docs: Added large-community documentation
David Lamparter [Mon, 11 Sep 2017 08:59:53 +0000 (10:59 +0200)]
Merge pull request #1128 from subsecond/patch-3
Build FRR using branch stable/3.0
Donald Sharp [Mon, 31 Jul 2017 12:52:10 +0000 (08:52 -0400)]
vtysh: Fix shell executed commands
Pretty much all shell executed commands from vtysh were
not behaving correctly due to errors introduced in
switching to the new cli.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Nigel Kukard [Sat, 9 Sep 2017 10:27:16 +0000 (10:27 +0000)]
doc: Cleaned up BGP showing of information section
Signed-off-by: Nigel Kukard <nkukard@lbsd.net>
Nigel Kukard [Sat, 9 Sep 2017 10:15:26 +0000 (10:15 +0000)]
doc: English language cleanup
Signed-off-by: Nigel Kukard <nkukard@lbsd.net>
Nigel Kukard [Sat, 9 Sep 2017 10:09:27 +0000 (10:09 +0000)]
doc: Moved AS regular expressions to BGP regular expressions
Regular expressions are used throughout in bgp commands, it
should not be in a section under as paths which cannot be
easily found.
Signed-off-by: Nigel Kukard <nkukard@lbsd.net>
Nigel Kukard [Sat, 9 Sep 2017 09:51:09 +0000 (09:51 +0000)]
doc: Clarified the use of show bgp ipv4/ipv6 for communities
Signed-off-by: Nigel Kukard <nkukard@lbsd.net>
Donald Sharp [Fri, 26 May 2017 20:19:08 +0000 (16:19 -0400)]
nhrpd: Fix missing include for 'access_list_init' function
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Quentin Young [Fri, 7 Apr 2017 17:40:11 +0000 (17:40 +0000)]
lib: add #pragma's to ignore flex sign cmp error
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
Nigel Kukard [Fri, 8 Sep 2017 12:24:52 +0000 (12:24 +0000)]
docs: Added large-community documentation
Closes #1140
Signed-off-by: Nigel Kukard <nkukard@lbsd.net>
Manuel Schweizer [Fri, 8 Sep 2017 10:48:39 +0000 (12:48 +0200)]
Build FRR using branch stable/3.0
Change all build instructions to include checkout of the respective branch.
Donald Sharp [Fri, 8 Sep 2017 00:30:34 +0000 (20:30 -0400)]
Merge pull request #1126 from subsecond/patch-2
Typos and formatting
Manuel Schweizer [Thu, 7 Sep 2017 18:51:35 +0000 (20:51 +0200)]
Build FRR using branch stable/3.0
This is the documentation for Ubuntu 16.04 in branch stable/3.0. Hence it is important to checkout the respective branch before building FRR.
Manuel Schweizer [Thu, 7 Sep 2017 17:25:24 +0000 (19:25 +0200)]
Typos and formatting
Donald Sharp [Thu, 7 Sep 2017 13:39:54 +0000 (09:39 -0400)]
Merge pull request #1116 from opensourcerouting/attr-refcount-kill
[3.0] kill bgp_attr_refcount()
David Lamparter [Thu, 7 Sep 2017 12:51:00 +0000 (14:51 +0200)]
bgpd: fix lcommunity refs in table-map
bgp_attr_deep_dup() needs to be removed just like bgp_attr_refcount(),
but that's a little too intrusive for the 3.0 branch at this point.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
David Lamparter [Thu, 7 Sep 2017 12:24:00 +0000 (14:24 +0200)]
bgpd: kill bgp_attr_refcount()
This attempt at optimization has cost us more than a week's worth of
time on several people hunting down the subtle bug that it was missing
an increment on attr->lcommunity.
This is absolutely not worth the maintenance cost.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Donald Sharp [Fri, 10 Mar 2017 12:59:52 +0000 (07:59 -0500)]
bgpd: Modify attr->flag to be 64 bit
With the some current bgp drafts the Attribute number has
surpassed 32. Which is a bit unfortunate in that we keep
track of the attributes via a bitfield based on the attribute #.
For the moment since I am not aware of Attribute #'s being
greater than 64, convert the flag to 64 bit and allow the
bit shifting to know about it.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Sun, 3 Sep 2017 15:29:04 +0000 (11:29 -0400)]
Merge pull request #1097 from nkukard/nk3.0
Large community fixes (critical)