From 500fe387a0e4ff474e3f85a317ac73f733dccf01 Mon Sep 17 00:00:00 2001 From: Rafael Zalamena Date: Wed, 6 Jul 2022 07:49:56 -0300 Subject: [PATCH] bfdd: fix coverity scan resource leak Close the descriptor if something fails and we don't return it. Signed-off-by: Rafael Zalamena --- bfdd/bfd_packet.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bfdd/bfd_packet.c b/bfdd/bfd_packet.c index 6b0afef65..23778c82d 100644 --- a/bfdd/bfd_packet.c +++ b/bfdd/bfd_packet.c @@ -1569,6 +1569,7 @@ int bp_echo_socket(const struct vrf *vrf) -1) { zlog_warn("%s: setsockopt(SO_ATTACH_FILTER): %s", __func__, strerror(errno)); + close(s); return -1; } @@ -1579,6 +1580,7 @@ int bp_echo_socket(const struct vrf *vrf) if (bind(s, (struct sockaddr *)&sll, sizeof(sll)) < 0) { zlog_warn("Failed to bind echo socket: %s", safe_strerror(errno)); + close(s); return -1; } -- 2.39.2