bindings: protect do_release_file_info() with mutex

Add a mutex to do_release_file_info to avoid lxcfs crash when stopping
multiple containers concurrently

Signed-off-by: tomponline <tomp@tomp.uk>
[christian.brauner@ubuntu.com: use correct commit message style]
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

diff --git a/bindings.c b/bindings.c
index 097ca81573539f03987568bd5f8c1bcc853c0004..29855d518cf25ea1c4e0811d1c3754f0667aa29e 100644 (file)
--- a/bindings.c
+++ b/bindings.c
@@ -2169,11 +2169,16 @@ out:
        return ret;
 }
 
+static pthread_mutex_t do_release_file_info_lock = PTHREAD_MUTEX_INITIALIZER;
+
 static void do_release_file_info(struct fuse_file_info *fi)
 {
+       lock_mutex(&do_release_file_info_lock);
+
        struct file_info *f = (struct file_info *)fi->fh;
 
        if (!f)
+               unlock_mutex(&do_release_file_info_lock);
                return;
 
        fi->fh = 0;
@@ -2188,6 +2193,8 @@ static void do_release_file_info(struct fuse_file_info *fi)
        f->buf = NULL;
        free(f);
        f = NULL;
+
+       unlock_mutex(&do_release_file_info_lock);
 }
 
 int cg_releasedir(const char *path, struct fuse_file_info *fi)