]> git.proxmox.com Git - mirror_qemu.git/commit
device_tree: Fix integer overflowing in load_device_tree()
authorMarkus Armbruster <armbru@redhat.com>
Tue, 9 Apr 2019 17:40:18 +0000 (19:40 +0200)
committerAlistair Francis <alistair.francis@wdc.com>
Tue, 9 Apr 2019 23:35:40 +0000 (16:35 -0700)
commit065e6298a75164b4347682b63381dbe752c2b156
treebe396b9fa2655a5947fcbed48ceb087f86bf2397
parentf151f8aca5cf5da24f6eb743a55a2233091ae532
device_tree: Fix integer overflowing in load_device_tree()

If the value of get_image_size() exceeds INT_MAX / 2 - 10000, the
computation of @dt_size overflows to a negative number, which then
gets converted to a very large size_t for g_malloc0() and
load_image_size().  In the (fortunately improbable) case g_malloc0()
succeeds and load_image_size() survives, we'd assign the negative
number to *sizep.  What that would do to the callers I can't say, but
it's unlikely to be good.

Fix by rejecting images whose size would overflow.

Reported-by: Kurtis Miller <kurtis.miller@nccgroup.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20190409174018.25798-1-armbru@redhat.com>
device_tree.c