]> git.proxmox.com Git - mirror_qemu.git/commit
virtio-scsi: restart DMA after iothread
authorStefan Hajnoczi <stefanha@redhat.com>
Thu, 20 Jun 2019 17:37:09 +0000 (18:37 +0100)
committerKevin Wolf <kwolf@redhat.com>
Mon, 8 Jul 2019 14:00:26 +0000 (16:00 +0200)
commit1a8c091c4ea5db3126514e3f7df678c9ee328802
tree15149cf49a60253597d6df16ca91380e681096db
parente965ffa70ac8ddc334dd5990f6907789bd9e6af6
virtio-scsi: restart DMA after iothread

When the 'cont' command resumes guest execution the vm change state
handlers are invoked.  Unfortunately there is no explicit ordering
between classic qemu_add_vm_change_state_handler() callbacks.  When two
layers of code both use vm change state handlers, we don't control which
handler runs first.

virtio-scsi with iothreads hits a deadlock when a failed SCSI command is
restarted and completes before the iothread is re-initialized.

This patch uses the new qdev_add_vm_change_state_handler() API to
guarantee that virtio-scsi's virtio change state handler executes before
the SCSI bus children.  This way DMA is restarted after the iothread has
re-initialized.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
hw/scsi/scsi-bus.c
hw/virtio/virtio.c