]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
selftests/powerpc: Remove Power9 copy_unaligned test
authorMichael Ellerman <mpe@ellerman.id.au>
Tue, 14 May 2019 09:01:00 +0000 (11:01 +0200)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Mon, 24 Jun 2019 14:21:33 +0000 (16:21 +0200)
BugLink: https://bugs.launchpad.net/bugs/1813118
This is a test of the ISA 3.0 "copy" instruction. That instruction has
an L field, which if set to 1 specifies that "the instruction
identifies the beginning of a move group" (pp 858). That's also
referred to as "copy first" vs "copy".

In ISA 3.0B the copy instruction does not have an L field, and the
corresponding bit in the instruction must be set to 1.

This test is generating a "copy" instruction, not a "copy first", and
so on Power9 (which implements 3.0B), this results in an illegal
instruction.

So just drop the test entirely. We still have copy_first_unaligned to
test the "copy first" behaviour.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Acked-by: Michael Neuling <mikey@neuling.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
(cherry picked from commit 83039f22ba2f6aff935a2acbb6bf671374e8317d)
Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
Acked-by: Connor Kuehl <connor.kuehl@canonical.com>
Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
tools/testing/selftests/powerpc/alignment/.gitignore
tools/testing/selftests/powerpc/alignment/Makefile
tools/testing/selftests/powerpc/alignment/copy_unaligned.c [deleted file]

index 1d980e3d703998e12c668a7324aa997e4f726a01..d1e675418e1c0fcebe7bd02a40e61395e279f7bd 100644 (file)
@@ -1,4 +1,3 @@
-copy_unaligned
 copy_first_unaligned
 paste_unaligned
 paste_last_unaligned
index 083a48a008b4290882396313dd98d269eba9f550..2d09d0e28b352343c48d9f30962eb137bf45209b 100644 (file)
@@ -1,4 +1,4 @@
-TEST_GEN_PROGS := copy_unaligned copy_first_unaligned paste_unaligned \
+TEST_GEN_PROGS := copy_first_unaligned paste_unaligned \
        paste_last_unaligned alignment_handler
 
 include ../../lib.mk
diff --git a/tools/testing/selftests/powerpc/alignment/copy_unaligned.c b/tools/testing/selftests/powerpc/alignment/copy_unaligned.c
deleted file mode 100644 (file)
index 3a4e264..0000000
+++ /dev/null
@@ -1,41 +0,0 @@
-/*
- * Copyright 2016, Chris Smart, IBM Corporation.
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation; either version
- * 2 of the License, or (at your option) any later version.
- *
- * Calls to copy which are not 128-byte aligned should be caught
- * and sent a SIGBUS.
- *
- */
-
-#include <string.h>
-#include <unistd.h>
-#include "utils.h"
-#include "instructions.h"
-#include "copy_paste_unaligned_common.h"
-
-unsigned int expected_instruction = PPC_INST_COPY;
-unsigned int instruction_mask = 0xfc0007fe;
-
-int test_copy_unaligned(void)
-{
-       /* Only run this test on a P9 or later */
-       SKIP_IF(!have_hwcap2(PPC_FEATURE2_ARCH_3_00));
-
-       /* Register our signal handler with SIGBUS */
-       setup_signal_handler();
-
-       /* +1 makes buf unaligned */
-       copy(cacheline_buf+1);
-
-       /* We should not get here */
-       return 1;
-}
-
-int main(int argc, char *argv[])
-{
-       return test_harness(test_copy_unaligned, "test_copy_unaligned");
-}