KVM: arm64: vgic-v3: Add ICV_EOIR1_EL1 handler

BugLink: https://bugs.launchpad.net/bugs/1673564
Add a handler for writing the guest's view of the ICC_EOIR1_EL1
register. This involves dropping the priority of the interrupt,
and deactivating it if required (EOImode == 0).

Tested-by: Alexander Graf <agraf@suse.de>
Acked-by: David Daney <david.daney@cavium.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Reviewed-by: Christoffer Dall <cdall@linaro.org>
Signed-off-by: Christoffer Dall <cdall@linaro.org>
(backported from commit b6f49035b4bf6e2709f2a5fed3107f5438c1fd02)
[ dannf: Dropped SYS_ prefix on ICV_EOIR1_EL1 macro, which wasn't
  added upstream until 0e9884fe ]
Signed-off-by: dann frazier <dann.frazier@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

diff --git a/include/linux/irqchip/arm-gic-v3.h b/include/linux/irqchip/arm-gic-v3.h
index 53095d085217a5af279ceda8592e42accc07d6b1..cad34dc03ad5fffac33ce8bd0fe333eb4e40f3c8 100644 (file)
--- a/include/linux/irqchip/arm-gic-v3.h
+++ b/include/linux/irqchip/arm-gic-v3.h
@@ -404,6 +404,8 @@
 
 #define ICH_HCR_EN                     (1 << 0)
 #define ICH_HCR_UIE                    (1 << 1)
+#define ICH_HCR_EOIcount_SHIFT         27
+#define ICH_HCR_EOIcount_MASK          (0x1f << ICH_HCR_EOIcount_SHIFT)
 
 #define ICH_VMCR_CTLR_SHIFT            0
 #define ICH_VMCR_CTLR_MASK             (0x21f << ICH_VMCR_CTLR_SHIFT)

diff --git a/virt/kvm/arm/hyp/vgic-v3-sr.c b/virt/kvm/arm/hyp/vgic-v3-sr.c
index dff42ae5ef3dda77710a88856c89b2d4b51bd6f7..1af7f94a525592a12b88421d157bf21b8389d891 100644 (file)
--- a/virt/kvm/arm/hyp/vgic-v3-sr.c
+++ b/virt/kvm/arm/hyp/vgic-v3-sr.c
@@ -481,6 +481,26 @@ static int __hyp_text __vgic_v3_highest_priority_lr(struct kvm_vcpu *vcpu,
        return lr;
 }
 
+static int __hyp_text __vgic_v3_find_active_lr(struct kvm_vcpu *vcpu,
+                                              int intid, u64 *lr_val)
+{
+       unsigned int used_lrs = vcpu->arch.vgic_cpu.used_lrs;
+       int i;
+
+       for (i = 0; i < used_lrs; i++) {
+               u64 val = __gic_v3_get_lr(i);
+
+               if ((val & ICH_LR_VIRTUAL_ID_MASK) == intid &&
+                   (val & ICH_LR_ACTIVE_BIT)) {
+                       *lr_val = val;
+                       return i;
+               }
+       }
+
+       *lr_val = ICC_IAR1_EL1_SPURIOUS;
+       return -1;
+}
+
 static int __hyp_text __vgic_v3_get_highest_active_priority(void)
 {
        u8 nr_apr_regs = vtr_to_nr_apr_regs(read_gicreg(ICH_VTR_EL2));
@@ -574,6 +594,44 @@ static void __hyp_text __vgic_v3_set_active_priority(u8 pri, u32 vmcr, int grp)
        }
 }
 
+static int __hyp_text __vgic_v3_clear_highest_active_priority(void)
+{
+       u8 nr_apr_regs = vtr_to_nr_apr_regs(read_gicreg(ICH_VTR_EL2));
+       u32 hap = 0;
+       int i;
+
+       for (i = 0; i < nr_apr_regs; i++) {
+               u32 ap0, ap1;
+               int c0, c1;
+
+               ap0 = __vgic_v3_read_ap0rn(i);
+               ap1 = __vgic_v3_read_ap1rn(i);
+               if (!ap0 && !ap1) {
+                       hap += 32;
+                       continue;
+               }
+
+               c0 = ap0 ? __ffs(ap0) : 32;
+               c1 = ap1 ? __ffs(ap1) : 32;
+
+               /* Always clear the LSB, which is the highest priority */
+               if (c0 < c1) {
+                       ap0 &= ~BIT(c0);
+                       __vgic_v3_write_ap0rn(ap0, i);
+                       hap += c0;
+               } else {
+                       ap1 &= ~BIT(c1);
+                       __vgic_v3_write_ap1rn(ap1, i);
+                       hap += c1;
+               }
+
+               /* Rescale to 8 bits of priority */
+               return hap << __vgic_v3_bpr_min();
+       }
+
+       return GICv3_IDLE_PRIORITY;
+}
+
 static void __hyp_text __vgic_v3_read_iar(struct kvm_vcpu *vcpu, u32 vmcr, int rt)
 {
        u64 lr_val;
@@ -610,6 +668,65 @@ spurious:
        vcpu_set_reg(vcpu, rt, ICC_IAR1_EL1_SPURIOUS);
 }
 
+static void __hyp_text __vgic_v3_clear_active_lr(int lr, u64 lr_val)
+{
+       lr_val &= ~ICH_LR_ACTIVE_BIT;
+       if (lr_val & ICH_LR_HW) {
+               u32 pid;
+
+               pid = (lr_val & ICH_LR_PHYS_ID_MASK) >> ICH_LR_PHYS_ID_SHIFT;
+               gic_write_dir(pid);
+       }
+
+       __gic_v3_set_lr(lr_val, lr);
+}
+
+static void __hyp_text __vgic_v3_bump_eoicount(void)
+{
+       u32 hcr;
+
+       hcr = read_gicreg(ICH_HCR_EL2);
+       hcr += 1 << ICH_HCR_EOIcount_SHIFT;
+       write_gicreg(hcr, ICH_HCR_EL2);
+}
+
+static void __hyp_text __vgic_v3_write_eoir(struct kvm_vcpu *vcpu, u32 vmcr, int rt)
+{
+       u32 vid = vcpu_get_reg(vcpu, rt);
+       u64 lr_val;
+       u8 lr_prio, act_prio;
+       int lr, grp;
+
+       grp = __vgic_v3_get_group(vcpu);
+
+       /* Drop priority in any case */
+       act_prio = __vgic_v3_clear_highest_active_priority();
+
+       /* If EOIing an LPI, no deactivate to be performed */
+       if (vid >= VGIC_MIN_LPI)
+               return;
+
+       /* EOImode == 1, nothing to be done here */
+       if (vmcr & ICH_VMCR_EOIM_MASK)
+               return;
+
+       lr = __vgic_v3_find_active_lr(vcpu, vid, &lr_val);
+       if (lr == -1) {
+               __vgic_v3_bump_eoicount();
+               return;
+       }
+
+       lr_prio = (lr_val & ICH_LR_PRIORITY_MASK) >> ICH_LR_PRIORITY_SHIFT;
+
+       /* If priorities or group do not match, the guest has fscked-up. */
+       if (grp != !!(lr_val & ICH_LR_GROUP) ||
+           __vgic_v3_pri_to_pre(lr_prio, vmcr, grp) != act_prio)
+               return;
+
+       /* Let's now perform the deactivation */
+       __vgic_v3_clear_active_lr(lr, lr_val);
+}
+
 static void __hyp_text __vgic_v3_read_igrpen1(struct kvm_vcpu *vcpu, u32 vmcr, int rt)
 {
        vcpu_set_reg(vcpu, rt, !!(vmcr & ICH_VMCR_ENG1_MASK));
@@ -677,6 +794,9 @@ int __hyp_text __vgic_v3_perform_cpuif_access(struct kvm_vcpu *vcpu)
        case ICC_IAR1_EL1:
                fn = __vgic_v3_read_iar;
                break;
+       case ICC_EOIR1_EL1:
+               fn = __vgic_v3_write_eoir;
+               break;
        case ICC_GRPEN1_EL1:
                if (is_read)
                        fn = __vgic_v3_read_igrpen1;