]> git.proxmox.com Git - mirror_zfs.git/commit
zdb -L should skip leak detection altogether
authorSerapheim Dimitropoulos <serapheimd@gmail.com>
Wed, 30 Jan 2019 17:54:27 +0000 (09:54 -0800)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Wed, 30 Jan 2019 17:54:27 +0000 (09:54 -0800)
commit21e7cf5da89f55ce98ec1115726b150e19eefe89
tree0355140529f133643b1cdb9a9f3da417d5a3a2e7
parent466f55334ac9b353948d4309bbcd44573e9a3024
zdb -L should skip leak detection altogether

Currently the point of -L option in zdb is to  disable leak
tracing and the loading of space maps because they are expensive,
yet still do leak detection in terms of space. Unfortunately,
there is a scenario where this is a lie. If we are using zdb -L
on a pool where a vdev is being removed, zdb_claim_removing()
will open the metaslab space maps of that device.

This patch makes it so zdb -L skips leak detection altogether
and ensures that no space maps are loaded.

Reviewed-by: Matt Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Serapheim Dimitropoulos <serapheim@delphix.com>
Closes #8335
cmd/zdb/zdb.c
man/man8/zdb.8