From: Serapheim Dimitropoulos <serapheimd@gmail.com>
Date: Mon, 25 Feb 2019 19:08:52 +0000 (-0800)
Subject: Error path in metaslab_load_impl() forgets to drop ms_sync_lock
X-Git-Tag: zfs-0.8.0~158
X-Git-Url: https://git.proxmox.com/?p=mirror_zfs.git;a=commitdiff_plain;h=8eef997679ba54547f7d361553d21b3291f41ae7

Error path in metaslab_load_impl() forgets to drop ms_sync_lock

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Giuseppe Di Natale <guss80@gmail.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Serapheim Dimitropoulos <serapheim@delphix.com>
Closes #8444
---

diff --git a/module/zfs/metaslab.c b/module/zfs/metaslab.c
index 9f6f0048f..8380897a9 100644
--- a/module/zfs/metaslab.c
+++ b/module/zfs/metaslab.c
@@ -1682,8 +1682,10 @@ metaslab_load_impl(metaslab_t *msp)
 	mutex_enter(&msp->ms_lock);
 	ASSERT(!msp->ms_condensing);
 
-	if (error != 0)
+	if (error != 0) {
+		mutex_exit(&msp->ms_sync_lock);
 		return (error);
+	}
 
 	ASSERT3P(msp->ms_group, !=, NULL);
 	msp->ms_loaded = B_TRUE;