From b5d693581d6238942997e1493ddfafa30b1e28f2 Mon Sep 17 00:00:00 2001 From: Tom Caputi Date: Wed, 23 Jan 2019 14:38:05 -0500 Subject: [PATCH] Fix bad kmem_free() in zvol_rename_minors_impl() Currently, zvol_rename_minors_impl() calls kmem_asprintf() to allocate and initialize a string. This function is a thin wrapper around the kernel's kvasprintf() and does not call into the SPL's kmem tracking code when it is enabled. However, this function frees the string with the tracked kmem_free() instead of the untracked strfree(), which causes the SPL kmem tracking code to believe that the function is attempting to free memory it never allocated, triggering an ASSERT. This patch simply corrects this issue. Reviewed by: Matt Ahrens Reviewed-by: Brian Behlendorf Signed-off-by: Tom Caputi Closes #8307 --- module/zfs/zvol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/module/zfs/zvol.c b/module/zfs/zvol.c index 7395dcb8d..7ca18e138 100644 --- a/module/zfs/zvol.c +++ b/module/zfs/zvol.c @@ -2267,7 +2267,7 @@ zvol_rename_minors_impl(const char *oldname, const char *newname) zv->zv_name[oldnamelen], zv->zv_name + oldnamelen + 1); zvol_rename_minor(zv, name); - kmem_free(name, strlen(name + 1)); + strfree(name); } mutex_exit(&zv->zv_state_lock); -- 2.39.2