From: Stoiko Ivanov <s.ivanov@proxmox.com>
Date: Wed, 16 Jun 2021 18:36:40 +0000 (+0200)
Subject: api: nodeconfig: validate acme config before writing
X-Git-Url: https://git.proxmox.com/?p=pmg-api.git;a=commitdiff_plain;h=08d71f69082b947fc6da756cbe3a40d4c0cafac6

api: nodeconfig: validate acme config before writing

Currently it is possible to add the same domains as different
acmedomainX keys to the node config, which prevents the user from
ordering certificates later.

This patch adds a call to get_acme_conf, which does the semantic
validation (and is also used in all other sites, which read the
config).

Reported in our community forum:
https://forum.proxmox.com/threads/lets-encrypt-cert-on-gui-not-working.91014/

quickly tested in my setup, by successfully adding the same domain
twice without the patch, and failing to do so with it applied.

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---

diff --git a/src/PMG/API2/NodeConfig.pm b/src/PMG/API2/NodeConfig.pm
index 284f663..bfbbacd 100644
--- a/src/PMG/API2/NodeConfig.pm
+++ b/src/PMG/API2/NodeConfig.pm
@@ -81,6 +81,9 @@ __PACKAGE__->register_method ({
 		$conf->{$opt} = $param->{$opt};
 	    }
 
+	    #validate the acme config (check for duplicates)
+	    PMG::NodeConfig::get_acme_conf($conf);
+
 	    PMG::NodeConfig::write_config($conf);
 	});