From: Thomas Lamprecht Date: Fri, 23 Oct 2020 12:07:00 +0000 (+0200) Subject: drop jslint hints X-Git-Url: https://git.proxmox.com/?p=pmg-gui.git;a=commitdiff_plain;h=f057ca9085cffc86d38c05884b2a9b26c48caed3 drop jslint hints Signed-off-by: Thomas Lamprecht --- diff --git a/js/AttachmentQuarantine.js b/js/AttachmentQuarantine.js index f199ed1..188dae5 100644 --- a/js/AttachmentQuarantine.js +++ b/js/AttachmentQuarantine.js @@ -1,5 +1,3 @@ -/*jslint confusion: true*/ -/*format is a string and a function*/ Ext.define('pmg-attachment-list', { extend: 'Ext.data.Model', fields: ['id', 'envelope_sender', 'from', 'sender', 'receiver', 'subject', diff --git a/js/ClamAVDatabase.js b/js/ClamAVDatabase.js index d498fda..36da444 100644 --- a/js/ClamAVDatabase.js +++ b/js/ClamAVDatabase.js @@ -10,13 +10,10 @@ Ext.define('PMG.ClamAVDatabaseConfig', { me.add_text_row('dbmirror', gettext('Database Mirror'), { deleteEmpty: true, defaultValue: 'database.clamav.net' }); - /*jslint confusion: true*/ - /*defaultValue is a string above*/ me.add_boolean_row('safebrowsing', gettext('Google Safe Browsing'), { defaultValue: 1 }); me.add_boolean_row('scriptedupdates', gettext('Incremental Download'), { defaultValue: 0 }); - /*jslint confusion: false*/ var baseurl = '/config/clamav'; @@ -112,10 +109,7 @@ Ext.define('PMG.ClamAVDatabaseStatus', { me.callParent(); - /*jslint confusion: true*/ - /*monStoreErrors is a bool above*/ Proxmox.Utils.monStoreErrors(me.getView(), me.store, true); - /*jslint confusion: false*/ }, }); diff --git a/js/ClusterAdministration.js b/js/ClusterAdministration.js index deea786..e22a083 100644 --- a/js/ClusterAdministration.js +++ b/js/ClusterAdministration.js @@ -105,8 +105,6 @@ Ext.define('PMG.ClusterAddNodeWindow', { ], }); -/*jslint confusion: true*/ -/* bind is a function and object */ Ext.define('PMG.ClusterAdministration', { extend: 'Ext.tab.Panel', xtype: 'pmgClusterAdministration', diff --git a/js/ConfigPanel.js b/js/ConfigPanel.js index d18ee6b..27b767c 100644 --- a/js/ConfigPanel.js +++ b/js/ConfigPanel.js @@ -177,11 +177,9 @@ Ext.define('PMG.panel.Config', { me.items = me.items || []; me.savedItems = {}; - /*jslint confusion:true*/ if (me.items[0]) { me.firstItem = me.items[0].itemId; } - /*jslint confusion:false*/ me.store = Ext.create('Ext.data.TreeStore', { root: { diff --git a/js/ContactStatistics.js b/js/ContactStatistics.js index 2e2d9b7..6c9d2d4 100644 --- a/js/ContactStatistics.js +++ b/js/ContactStatistics.js @@ -1,5 +1,3 @@ -/*jslint confusion: true*/ -/* filter is a function and object */ Ext.define('PMG.ContactDetails', { extend: 'Ext.grid.GridPanel', xtype: 'pmgContactDetails', diff --git a/js/Dashboard.js b/js/Dashboard.js index b24a0c9..c92b2f0 100644 --- a/js/Dashboard.js +++ b/js/Dashboard.js @@ -1,10 +1,3 @@ -/*jslint confusion: true*/ -/* load is a function and string - * hours is a number and string - * timespan is a number and string - * bind is a function and object - * handler is a function and string - */ Ext.define('PMG.Dashboard', { extend: 'Ext.panel.Panel', xtype: 'pmgDashboard', diff --git a/js/FetchmailEdit.js b/js/FetchmailEdit.js index 0d517c0..512421f 100644 --- a/js/FetchmailEdit.js +++ b/js/FetchmailEdit.js @@ -1,5 +1,3 @@ -/*jslint confusion: true*/ -/*value is string and number*/ Ext.define('PMG.FetchmailEdit', { extend: 'Proxmox.window.Edit', xtype: 'pmgFetchmailEdit', diff --git a/js/FilterProxy.js b/js/FilterProxy.js index 7b4a0cf..de4cd06 100644 --- a/js/FilterProxy.js +++ b/js/FilterProxy.js @@ -17,9 +17,7 @@ Ext.define('PMG.FilterProxy', { if (filter.config.id === me.filterId) { var v = filter.getValue(); if (v !== undefined && v !== '') { - /*jslint confusion: true */ params.filter = v; - /*jslint confusion: false */ } } } diff --git a/js/LDAPConfig.js b/js/LDAPConfig.js index 9fce957..0a4937e 100644 --- a/js/LDAPConfig.js +++ b/js/LDAPConfig.js @@ -1,10 +1,3 @@ -/*jslint confusion: true*/ -/* reload is function and string, - * height is number and string, - * hidden is bool and string, - * bind is function and object, - * callback is function and string - */ Ext.define('pmg-ldap-config', { extend: 'Ext.data.Model', fields: ['profile', 'server1', 'server2', 'comment', diff --git a/js/MailProxyOptions.js b/js/MailProxyOptions.js index 46e51b1..b151350 100644 --- a/js/MailProxyOptions.js +++ b/js/MailProxyOptions.js @@ -32,8 +32,6 @@ Ext.define('PMG.MailProxyOptions', { return Proxmox.Utils.yesText + ' (' + value + ')'; }; - /*jslint confusion: true*/ - /*defaultValue is string and number*/ me.add_combobox_row('verifyreceivers', gettext('Verify Receivers'), { renderer: render_verifyreceivers, defaultValue: '__default__', @@ -43,7 +41,6 @@ Ext.define('PMG.MailProxyOptions', { ['450', render_verifyreceivers('450')], ['550', render_verifyreceivers('550')]], }); - /*jslint confusion: false*/ me.add_boolean_row('greylist', gettext('Use Greylisting for IPv4'), { defaultValue: 1 }); @@ -73,11 +70,8 @@ Ext.define('PMG.MailProxyOptions', { me.add_integer_row('message_rate_limit', gettext('Client Message Rate Limit'), { defaultValue: 0, minValue: 0 }); - /*jslint confusion: true*/ - /*defaultValue is string and number*/ me.add_text_row('banner', gettext('SMTPD Banner'), { deleteEmpty: true, defaultValue: 'ESMTP Proxmox' }); - /*jslint confusion: false*/ me.add_boolean_row('ndr_on_block', gettext('Send NDR on Blocked E-Mails')); // FIXME allow to pass onlineHelp to ObjectGrid's add_xyz_row.. diff --git a/js/MyNetworks.js b/js/MyNetworks.js index 16517c1..6c52f1a 100644 --- a/js/MyNetworks.js +++ b/js/MyNetworks.js @@ -79,7 +79,6 @@ Ext.define('PMG.MyNetworks', { { text: gettext('Create'), handler: function() { - /*jslint confusion: true*/ var config = { method: 'POST', url: "/api2/extjs/config/mynetworks", @@ -99,7 +98,6 @@ Ext.define('PMG.MyNetworks', { }, ], }; - /*jslint confusion: false*/ var win = Ext.createWidget('proxmoxWindowEdit', config); diff --git a/js/ReceiverStatistics.js b/js/ReceiverStatistics.js index bcc46b8..6378e06 100644 --- a/js/ReceiverStatistics.js +++ b/js/ReceiverStatistics.js @@ -1,5 +1,3 @@ -/*jslint confusion: true*/ -/* filter is a function and object */ Ext.define('PMG.ReceiverDetails', { extend: 'Ext.grid.GridPanel', xtype: 'pmgReceiverDetails', diff --git a/js/RelayDomains.js b/js/RelayDomains.js index a0f698b..0098e20 100644 --- a/js/RelayDomains.js +++ b/js/RelayDomains.js @@ -84,7 +84,6 @@ Ext.define('PMG.RelayDomains', { { text: gettext('Create'), handler: function() { - /*jslint confusion: true*/ var config = { method: 'POST', url: '/api2/extjs' + me.baseurl, @@ -104,7 +103,6 @@ Ext.define('PMG.RelayDomains', { }, ], }; - /*jslint confusion: false*/ var win = Ext.createWidget('proxmoxWindowEdit', config); diff --git a/js/RuleConfiguration.js b/js/RuleConfiguration.js index 261106c..93094c2 100644 --- a/js/RuleConfiguration.js +++ b/js/RuleConfiguration.js @@ -1,7 +1,3 @@ -/*jslint confusion: true*/ -/* bind is a function and object, - * callback is a function and string - */ Ext.define('pmg-rule-list', { extend: 'Ext.data.Model', fields: [ diff --git a/js/RuleInfo.js b/js/RuleInfo.js index 68eff02..b7802fa 100644 --- a/js/RuleInfo.js +++ b/js/RuleInfo.js @@ -1,5 +1,3 @@ -/*jslint confusion: true*/ -/* bind is a function function */ Ext.define('PMG.RuleInfo', { extend: 'Ext.panel.Panel', xtype: 'pmgRuleInfo', diff --git a/js/SenderStatistics.js b/js/SenderStatistics.js index b6ed5dd..43c5438 100644 --- a/js/SenderStatistics.js +++ b/js/SenderStatistics.js @@ -1,5 +1,3 @@ -/*jslint confusion: true*/ -/* filter is a function and object */ Ext.define('PMG.SenderDetails', { extend: 'Ext.grid.GridPanel', xtype: 'pmgSenderDetails', diff --git a/js/SpamDetectorLanguages.js b/js/SpamDetectorLanguages.js index e748922..970ac61 100644 --- a/js/SpamDetectorLanguages.js +++ b/js/SpamDetectorLanguages.js @@ -73,10 +73,7 @@ Ext.define('PMG.SpamDetectorLanguagesInputPanel', { if (!values.languages) { values.delete = 'languages'; } else if (Ext.isArray(values.languages)) { - /*jslint confusion: true*/ - /*languages is an array and string here*/ values.languages = values.languages.join(' '); - /*jslint confusion: false*/ } return values; diff --git a/js/SpamQuarantine.js b/js/SpamQuarantine.js index f3f6053..f5875bc 100644 --- a/js/SpamQuarantine.js +++ b/js/SpamQuarantine.js @@ -1,5 +1,3 @@ -/*jslint confusion: true*/ -/*format is a string and a function*/ Ext.define('pmg-spam-archive', { extend: 'Ext.data.Model', fields: [ diff --git a/js/SpamQuarantineOptions.js b/js/SpamQuarantineOptions.js index 6dce160..353fe7e 100644 --- a/js/SpamQuarantineOptions.js +++ b/js/SpamQuarantineOptions.js @@ -30,8 +30,6 @@ Ext.define('PMG.SpamQuarantineOptions', { return me.authmodeTextHash[value] || value; }; - /*jslint confusion: true*/ - /* defaultValue is a string and a number*/ me.add_combobox_row('authmode', gettext('Authentication mode'), { defaultValue: 'ticket', renderer: render_authmode, @@ -54,7 +52,6 @@ Ext.define('PMG.SpamQuarantineOptions', { ['verbose', render_reportstyle('verbose')], ['custom', render_reportstyle('custom')]], }); - /*jslint confusion: false*/ me.add_text_row('hostname', gettext('Quarantine Host'), { deleteEmpty: true, defaultValue: Proxmox.Utils.noneText }); diff --git a/js/UserEdit.js b/js/UserEdit.js index 7918d80..e212530 100644 --- a/js/UserEdit.js +++ b/js/UserEdit.js @@ -1,5 +1,3 @@ -/*jslint confusion: true*/ -/* submitvalue is string and bool */ Ext.define('PMG.UserEdit', { extend: 'Proxmox.window.Edit', alias: 'widget.pmgUserEdit', diff --git a/js/UserView.js b/js/UserView.js index 647544c..f81bd40 100644 --- a/js/UserView.js +++ b/js/UserView.js @@ -1,5 +1,3 @@ -/*jslint confusion: true*/ -/*renderer is string and function*/ Ext.define('pmg-users', { extend: 'Ext.data.Model', fields: [ diff --git a/js/Utils.js b/js/Utils.js index e730a3e..abd910d 100644 --- a/js/Utils.js +++ b/js/Utils.js @@ -809,11 +809,8 @@ Ext.define('PMG.Utils', { var from = Ext.htmlEncode(rec.data.from); var sender = Ext.htmlEncode(rec.data.sender); if (sender) { - /*jslint confusion: true*/ - /*format is a string above*/ from = Ext.String.format(gettext("{0} on behalf of {1}"), sender, from); - /*jslint confusion: false*/ } return '' + from + '
' + subject; }, diff --git a/js/VirusQuarantine.js b/js/VirusQuarantine.js index 29ec704..105a438 100644 --- a/js/VirusQuarantine.js +++ b/js/VirusQuarantine.js @@ -1,5 +1,3 @@ -/*jslint confusion: true*/ -/*format is a string and a function*/ Ext.define('pmg-virus-list', { extend: 'Ext.data.Model', fields: ['id', 'envelope_sender', 'from', 'sender', 'receiver', 'subject',